1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
|
# SPDX-FileCopyrightText: 2026 Dennis Fink <me+coding@dennisfink.me>
#
# SPDX-License-Identifier: BSD-3-Clause
"""Authenticated source-domain management and early endpoint rejection."""
import uuid
from datetime import UTC, datetime
from http import HTTPStatus
from unittest.mock import Mock
import pytest
import sqlalchemy as sa
from flask import Flask
from flask.testing import FlaskClient
from webmentions_ssg import db
from webmentions_ssg.models.moderation import AllowedDomain, BlockedDomain
from webmentions_ssg.models.received import ReceivedWebmention, ReceivedWebmentionStatus
from webmentions_ssg.moderation_policy import rejection_reason
from webmentions_ssg.tasks.verification import VerificationClaim
from .helpers import SOURCE_URL, TARGET_URL, create_received_webmention, log_in
def test_source_rules_require_login(client: FlaskClient) -> None:
for method, path, data in (
("get", "/moderation", None),
("post", "/moderation/blocked/add", {"domain": "bad.example"}),
("post", "/moderation/blocked/1/delete", None),
):
response = client.open(path, method=method.upper(), data=data)
assert response.status_code == HTTPStatus.FOUND
assert "/login" in response.headers["Location"]
def test_add_and_unblock_source_domain(app: Flask, client: FlaskClient) -> None:
log_in(app, client)
response = client.post("/moderation/blocked/add", data={"domain": "SPAM.Example."})
assert response.status_code == HTTPStatus.FOUND
assert response.headers["Location"].endswith("/moderation")
response = client.post("/moderation/blocked/add", data={"domain": "spam.example"})
assert response.status_code == HTTPStatus.FOUND
with app.app_context():
rows = db.session.scalars(sa.select(BlockedDomain)).all()
assert len(rows) == 1
assert rows[0].domain == "spam.example"
entry_id = rows[0].id
response = client.get("/moderation")
assert response.status_code == HTTPStatus.OK
assert b"spam.example" in response.data
assert b"Unblock" in response.data
assert b"Moderation" in response.data
response = client.post(f"/moderation/blocked/{entry_id}/delete")
assert response.status_code == HTTPStatus.FOUND
assert response.headers["Location"].endswith("/moderation")
with app.app_context():
assert db.session.scalar(sa.select(sa.func.count(BlockedDomain.id))) == 0
def test_allowlist_can_be_managed_while_mode_is_off(
app: Flask, client: FlaskClient
) -> None:
log_in(app, client)
response = client.post(
"/moderation/allowed/add", data={"domain": "friends.example"}
)
assert response.status_code == HTTPStatus.FOUND
with app.app_context():
row = db.session.scalar(sa.select(AllowedDomain))
assert row is not None
assert row.domain == "friends.example"
assert b"disabled" in client.get("/moderation").data
@pytest.mark.parametrize(
"domain", ["https://spam.example", "*.example.com", "example.com/path", "bad host"]
)
def test_invalid_domains_are_rejected(
client: FlaskClient, app: Flask, domain: str
) -> None:
log_in(app, client)
response = client.post("/moderation/blocked/add", data={"domain": domain})
assert response.status_code == HTTPStatus.BAD_REQUEST
def test_invalid_list_kind_and_missing_entry(app: Flask, client: FlaskClient) -> None:
log_in(app, client)
assert (
client.post("/moderation/nope/add", data={"domain": "test.org"}).status_code
== 404
)
assert client.post("/moderation/blocked/123/delete").status_code == 404
def test_block_selected_source_domains_deduplicates_and_preserves_mentions(
app: Flask, client: FlaskClient
) -> None:
from urllib.parse import parse_qs, urlsplit
log_in(app, client)
first = create_received_webmention(app, source="https://SPAM.Example./article")
same_domain = create_received_webmention(
app, source="https://spam.example/another-article"
)
second = create_received_webmention(app, source="https://second.example/article")
unselected = create_received_webmention(app, source="https://other.example/article")
with app.app_context():
db.session.add(BlockedDomain(domain="second.example"))
db.session.commit()
response = client.post(
"/received/bulk/block-sources",
query_string={"page": 3, "status": "verified", "sort": "source"},
data={"webmention_uuids": [str(first), str(same_domain), str(second)]},
)
assert response.status_code == HTTPStatus.FOUND
assert parse_qs(urlsplit(response.headers["Location"]).query) == {
"page": ["3"],
"status": ["verified"],
"sort": ["source"],
}
with app.app_context():
assert set(db.session.scalars(sa.select(BlockedDomain.domain))) == {
"spam.example",
"second.example",
}
for identifier in (first, same_domain, second, unselected):
assert db.session.get(ReceivedWebmention, identifier) is not None
assert (
rejection_reason("https://child.spam.example/post")
== "Source domain is blocked"
)
assert rejection_reason("https://other.example/post") is None
# Repeating the action is idempotent.
response = client.post(
"/received/bulk/block-sources",
data={"webmention_uuids": [str(first), str(same_domain)]},
)
assert response.status_code == HTTPStatus.FOUND
with app.app_context():
assert db.session.scalar(sa.select(sa.func.count(BlockedDomain.id))) == 2
def test_bulk_block_rejects_invalid_source_without_partial_changes(
app: Flask, client: FlaskClient
) -> None:
log_in(app, client)
valid = create_received_webmention(app, source="https://valid.example/post")
invalid = create_received_webmention(app, source="not-a-url")
response = client.post(
"/received/bulk/block-sources",
data={"webmention_uuids": [str(valid), str(invalid)]},
)
assert response.status_code == HTTPStatus.BAD_REQUEST
with app.app_context():
assert db.session.scalar(sa.select(sa.func.count(BlockedDomain.id))) == 0
def test_bulk_block_action_enforces_csrf(app: Flask, client: FlaskClient) -> None:
log_in(app, client)
identifier = create_received_webmention(app)
app.config["WTF_CSRF_ENABLED"] = True
response = client.post(
"/received/bulk/block-sources", data={"webmention_uuids": str(identifier)}
)
assert response.status_code == HTTPStatus.BAD_REQUEST
with app.app_context():
assert db.session.scalar(sa.select(sa.func.count(BlockedDomain.id))) == 0
def test_endpoint_rejects_blocked_without_queue_or_insert(
app: Flask, client: FlaskClient, monkeypatch: pytest.MonkeyPatch
) -> None:
from webmentions_ssg.views import endpoint
enqueue = Mock()
monkeypatch.setattr(endpoint, "verify_webmention", enqueue)
with app.app_context():
db.session.add(BlockedDomain(domain="source.example"))
db.session.commit()
response = client.post(
"/endpoint", data={"source": SOURCE_URL, "target": TARGET_URL}
)
assert response.status_code == HTTPStatus.FORBIDDEN
assert response.json == {"error": "Source domain is blocked"}
enqueue.assert_not_called()
with app.app_context():
assert db.session.scalar(sa.select(sa.func.count(ReceivedWebmention.uuid))) == 0
def test_allowlist_mode_rejects_unlisted_and_allows_listed(
app: Flask, client: FlaskClient, monkeypatch: pytest.MonkeyPatch
) -> None:
from webmentions_ssg.views import endpoint
app.config["ALLOWLIST_ENABLED"] = True
enqueue = Mock()
monkeypatch.setattr(endpoint, "verify_webmention", enqueue)
data = {"source": SOURCE_URL, "target": TARGET_URL}
assert client.post("/endpoint", data=data).status_code == HTTPStatus.FORBIDDEN
with app.app_context():
db.session.add(AllowedDomain(domain="source.example"))
db.session.commit()
assert client.post("/endpoint", data=data).status_code == HTTPStatus.CREATED
enqueue.assert_called_once()
def test_worker_checks_rules_before_fetch(
app: Flask, monkeypatch: pytest.MonkeyPatch
) -> None:
from webmentions_ssg.tasks import verification
claim = VerificationClaim(
webmention_uuid=uuid.uuid7(),
source=SOURCE_URL,
target=TARGET_URL,
lease_started_at=datetime.now(UTC),
)
fetch = Mock()
monkeypatch.setattr(verification, "source_mentions_target", fetch)
with app.app_context():
db.session.add(BlockedDomain(domain="source.example"))
db.session.commit()
assert verification.determine_verification_outcome(claim) == (
ReceivedWebmentionStatus.FAILED,
"Source domain is blocked",
)
fetch.assert_not_called()
def test_queued_worker_skips_fetch_after_source_is_blocked(
app: Flask, monkeypatch: pytest.MonkeyPatch
) -> None:
from webmentions_ssg.tasks import verification
with app.app_context():
mention = ReceivedWebmention(
uuid=uuid.uuid7(), source=SOURCE_URL, target=TARGET_URL
)
db.session.add(mention)
db.session.commit()
identifier = mention.uuid
# A user blocks the domain after the submission has already been queued.
db.session.add(BlockedDomain(domain="source.example"))
db.session.commit()
fetch = Mock()
monkeypatch.setattr(verification, "source_mentions_target", fetch)
verification.verify_webmention.call_local(identifier)
fetch.assert_not_called()
with app.app_context():
mention = db.session.get(ReceivedWebmention, identifier)
assert mention is not None
assert mention.status == ReceivedWebmentionStatus.FAILED
assert mention.failure_reason == "Source domain is blocked"
def test_admin_actions_enforce_csrf(app: Flask, client: FlaskClient) -> None:
log_in(app, client)
app.config["WTF_CSRF_ENABLED"] = True
assert (
client.post(
"/moderation/blocked/add", data={"domain": "spam.example"}
).status_code
== HTTPStatus.BAD_REQUEST
)
def test_block_domains_survives_unique_constraint_race(
app: Flask, monkeypatch: pytest.MonkeyPatch
) -> None:
from sqlalchemy.exc import IntegrityError
from webmentions_ssg.views.moderation import block_domains
with app.app_context():
session = db.session()
real_flush = session.flush
def simulated_concurrent_insert(*args: object, **kwargs: object) -> None:
if any(
isinstance(obj, BlockedDomain) and obj.domain == "a-loser.example"
for obj in session.new
):
raise IntegrityError("duplicate", {}, Exception("concurrent insert"))
real_flush(*args, **kwargs)
with monkeypatch.context() as patcher:
patcher.setattr(session, "flush", simulated_concurrent_insert)
assert block_domains({"a-loser.example", "b-winner.example"}) == 1
assert set(db.session.scalars(sa.select(BlockedDomain.domain))) == {
"b-winner.example"
}
def test_moderation_add_recovers_from_duplicate_insert_race(
app: Flask, client: FlaskClient, monkeypatch: pytest.MonkeyPatch
) -> None:
from sqlalchemy.exc import IntegrityError
log_in(app, client)
commit = Mock(side_effect=IntegrityError("duplicate", {}, Exception("race")))
rollback = Mock(wraps=db.session.rollback)
with monkeypatch.context() as patcher:
patcher.setattr(db.session, "commit", commit)
patcher.setattr(db.session, "rollback", rollback)
response = client.post(
"/moderation/blocked/add", data={"domain": "racing.example"}
)
assert response.status_code == HTTPStatus.FOUND
assert response.headers["Location"].endswith("/moderation")
commit.assert_called_once()
rollback.assert_called_once()
@pytest.mark.parametrize("kind", ["invalid", "blocked"])
def test_moderation_delete_rejects_bad_kind_or_invalid_form(
app: Flask,
client: FlaskClient,
monkeypatch: pytest.MonkeyPatch,
kind: str,
) -> None:
from webmentions_ssg.views import moderation
log_in(app, client)
form = Mock()
form.validate_on_submit.return_value = False
monkeypatch.setattr(moderation, "ConfirmActionForm", Mock(return_value=form))
with app.app_context():
entry = BlockedDomain(domain="example.test")
db.session.add(entry)
db.session.commit()
entry_id = entry.id
response = client.post(f"/moderation/{kind}/{entry_id}/delete")
assert response.status_code == (
HTTPStatus.NOT_FOUND if kind == "invalid" else HTTPStatus.BAD_REQUEST
)
with app.app_context():
assert db.session.get(BlockedDomain, entry_id) is not None
|