aboutsummaryrefslogtreecommitdiff
path: root/tests/views
diff options
context:
space:
mode:
Diffstat (limited to '')
-rw-r--r--tests/views/test_endpoint.py16
-rw-r--r--tests/views/test_moderation.py76
-rw-r--r--tests/views/test_received.py46
3 files changed, 138 insertions, 0 deletions
diff --git a/tests/views/test_endpoint.py b/tests/views/test_endpoint.py
index bf99ed4..63c17c6 100644
--- a/tests/views/test_endpoint.py
+++ b/tests/views/test_endpoint.py
@@ -529,3 +529,19 @@ def test_endpoint_records_initial_and_resubmission_events(
"Received submission",
"Resubmitted after cooldown",
]
+
+
+def test_submission_returns_none_when_competing_insert_cannot_be_found(
+ app: Flask, monkeypatch: pytest.MonkeyPatch
+) -> None:
+ from webmentions_ssg.views import endpoint
+
+ find = Mock(return_value=None)
+ insert = Mock(return_value=None)
+ monkeypatch.setattr(endpoint, "find_received_webmention", find)
+ monkeypatch.setattr(endpoint, "try_insert_received_webmention", insert)
+
+ with app.app_context():
+ assert endpoint.record_submission(SOURCE_URL, TARGET_URL) is None
+ assert find.call_count == 2
+ insert.assert_called_once_with(SOURCE_URL, TARGET_URL)
diff --git a/tests/views/test_moderation.py b/tests/views/test_moderation.py
index 78ff661..92446c4 100644
--- a/tests/views/test_moderation.py
+++ b/tests/views/test_moderation.py
@@ -276,3 +276,79 @@ def test_admin_actions_enforce_csrf(app: Flask, client: FlaskClient) -> None:
).status_code
== HTTPStatus.BAD_REQUEST
)
+
+
+def test_block_domains_survives_unique_constraint_race(
+ app: Flask, monkeypatch: pytest.MonkeyPatch
+) -> None:
+ from sqlalchemy.exc import IntegrityError
+
+ from webmentions_ssg.views.moderation import block_domains
+
+ with app.app_context():
+ session = db.session()
+ real_flush = session.flush
+
+ def simulated_concurrent_insert(*args: object, **kwargs: object) -> None:
+ if any(
+ isinstance(obj, BlockedDomain) and obj.domain == "a-loser.example"
+ for obj in session.new
+ ):
+ raise IntegrityError("duplicate", {}, Exception("concurrent insert"))
+ real_flush(*args, **kwargs)
+
+ with monkeypatch.context() as patcher:
+ patcher.setattr(session, "flush", simulated_concurrent_insert)
+ assert block_domains({"a-loser.example", "b-winner.example"}) == 1
+
+ assert set(db.session.scalars(sa.select(BlockedDomain.domain))) == {
+ "b-winner.example"
+ }
+
+
+def test_moderation_add_recovers_from_duplicate_insert_race(
+ app: Flask, client: FlaskClient, monkeypatch: pytest.MonkeyPatch
+) -> None:
+ from sqlalchemy.exc import IntegrityError
+
+ log_in(app, client)
+ commit = Mock(side_effect=IntegrityError("duplicate", {}, Exception("race")))
+ rollback = Mock(wraps=db.session.rollback)
+ with monkeypatch.context() as patcher:
+ patcher.setattr(db.session, "commit", commit)
+ patcher.setattr(db.session, "rollback", rollback)
+ response = client.post(
+ "/moderation/blocked/add", data={"domain": "racing.example"}
+ )
+
+ assert response.status_code == HTTPStatus.FOUND
+ assert response.headers["Location"].endswith("/moderation")
+ commit.assert_called_once()
+ rollback.assert_called_once()
+
+
+@pytest.mark.parametrize("kind", ["invalid", "blocked"])
+def test_moderation_delete_rejects_bad_kind_or_invalid_form(
+ app: Flask,
+ client: FlaskClient,
+ monkeypatch: pytest.MonkeyPatch,
+ kind: str,
+) -> None:
+ from webmentions_ssg.views import moderation
+
+ log_in(app, client)
+ form = Mock()
+ form.validate_on_submit.return_value = False
+ monkeypatch.setattr(moderation, "ConfirmActionForm", Mock(return_value=form))
+ with app.app_context():
+ entry = BlockedDomain(domain="example.test")
+ db.session.add(entry)
+ db.session.commit()
+ entry_id = entry.id
+
+ response = client.post(f"/moderation/{kind}/{entry_id}/delete")
+ assert response.status_code == (
+ HTTPStatus.NOT_FOUND if kind == "invalid" else HTTPStatus.BAD_REQUEST
+ )
+ with app.app_context():
+ assert db.session.get(BlockedDomain, entry_id) is not None
diff --git a/tests/views/test_received.py b/tests/views/test_received.py
index ed31dc5..baea6c7 100644
--- a/tests/views/test_received.py
+++ b/tests/views/test_received.py
@@ -1394,3 +1394,49 @@ def test_received_bulk_delete_preserves_only_remaining_history(
history = db.session.scalars(sa.select(ReceivedWebmentionStatusEvent)).all()
assert len(history) == 1
assert history[0].webmention_uuid == second
+
+
+@pytest.mark.parametrize("failure", ["csrf", "invalid-source"])
+def test_single_received_block_source_rejects_invalid_request(
+ app: Flask,
+ client: FlaskClient,
+ views_module: ModuleType,
+ monkeypatch: pytest.MonkeyPatch,
+ failure: str,
+) -> None:
+ log_in(app, client)
+ identifier = create_received_webmention(
+ app,
+ source="not-a-url" if failure == "invalid-source" else SOURCE_URL,
+ )
+ mock_admin_action_form(views_module, monkeypatch, valid=failure != "csrf")
+
+ response = client.post(f"/received/{identifier}/block-source")
+ assert response.status_code == HTTPStatus.BAD_REQUEST
+ with app.app_context():
+ from webmentions_ssg.models.moderation import BlockedDomain
+
+ assert db.session.scalar(sa.select(sa.func.count(BlockedDomain.id))) == 0
+
+
+def test_single_received_block_source_redirects_with_filters(
+ app: Flask, client: FlaskClient
+) -> None:
+ from webmentions_ssg.models.moderation import BlockedDomain
+
+ log_in(app, client)
+ identifier = create_received_webmention(app, source="https://spammer.example/post")
+ response = client.post(
+ f"/received/{identifier}/block-source",
+ query_string={"status": "verified", "page": 3},
+ )
+ assert response.status_code == HTTPStatus.FOUND
+ assert parse_qs(urlsplit(response.headers["Location"]).query) == {
+ "status": ["verified"],
+ "page": ["3"],
+ }
+ with app.app_context():
+ assert set(db.session.scalars(sa.select(BlockedDomain.domain))) == {
+ "spammer.example"
+ }
+ assert db.session.get(ReceivedWebmention, identifier) is not None