diff options
| author | Dennis Fink | 2026-10-31 19:33:49 +0100 |
|---|---|---|
| committer | Dennis Fink | 2026-10-31 19:33:49 +0100 |
| commit | 3a3284abe23e143cbb638877f47958c82afa3367 (patch) | |
| tree | 5409bb940d252756f502d545cc145b382f06a3a0 /webmentions_ssg/views.py | |
| parent | 40bdba0f2aa132f47326d2591e83039249ae2121 (diff) | |
| download | webmentions-ssg-3a3284abe23e143cbb638877f47958c82afa3367.tar.gz webmentions-ssg-3a3284abe23e143cbb638877f47958c82afa3367.zip | |
fix(core): harden login rate limiting behind proxies
Trust forwarded client addresses only for an explicitly configured
number of reverse-proxy hops so per-IP limits cannot be bypassed or
collapsed in proxied deployments.
Add a separate hashed per-username login limit across IPs to reduce
distributed credential-guessing attempts without storing raw usernames
in limiter keys.
Diffstat (limited to 'webmentions_ssg/views.py')
| -rw-r--r-- | webmentions_ssg/views.py | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/webmentions_ssg/views.py b/webmentions_ssg/views.py index 0836869..5b563f0 100644 --- a/webmentions_ssg/views.py +++ b/webmentions_ssg/views.py @@ -4,6 +4,7 @@ """Provide routes for authentication and Webmention administration.""" +import hashlib import secrets import uuid from datetime import UTC, datetime, timedelta @@ -23,6 +24,7 @@ from flask import ( url_for, ) from flask.typing import ResponseReturnValue +from flask_limiter.util import get_remote_address from flask_login import current_user, login_required, login_user, logout_user from sqlalchemy.engine import CursorResult from sqlalchemy.orm import selectinload @@ -42,6 +44,16 @@ DUMMY_USER = User(username=secrets.token_urlsafe()) DUMMY_USER.password = secrets.token_urlsafe() +def login_username_limit_key() -> str: + """Group submitted usernames across IPs without storing raw account names.""" + username = request.form.get("username", "").strip().casefold() + if not username: + # A missing username must not put all clients into one global bucket. + return f"missing-username:{get_remote_address()}" + digest = hashlib.sha256(username.encode("utf-8")).hexdigest() + return f"username:{digest}" + + @root_page.route("/") def index() -> ResponseReturnValue: """ @@ -54,6 +66,12 @@ def index() -> ResponseReturnValue: @root_page.route("/login", methods=["GET", "POST"]) @LIMITER.limit( + lambda: current_app.config["LOGIN_USERNAME_RATE_LIMIT"], + key_func=login_username_limit_key, + methods=["POST"], + error_message="Too many login attempts. Please try again later.", +) +@LIMITER.limit( lambda: current_app.config["LOGIN_RATE_LIMIT"], methods=["POST"], error_message="Too many login attempts. Please try again later.", |
