aboutsummaryrefslogtreecommitdiff
path: root/webmentions_ssg/models.py
diff options
context:
space:
mode:
authorDennis Fink2026-11-13 20:49:15 +0100
committerDennis Fink2026-11-13 20:49:15 +0100
commitca71bf1f30e118dd5bade3cff817d5bbd09f680a (patch)
tree9c20d8e948581eb7689eacc9e531360ab7b459ff /webmentions_ssg/models.py
parent82495162be98323fc56a35f2c2a59c143a765136 (diff)
downloadwebmentions-ssg-ca71bf1f30e118dd5bade3cff817d5bbd09f680a.tar.gz
webmentions-ssg-ca71bf1f30e118dd5bade3cff817d5bbd09f680a.zip
refactor(core): clarify Webmention mutation APIs
Make in-place reset and reopen helpers return `None` so callers no longer perform pointless self-reassignment. Split explicit resend behavior into its own method instead of hiding it behind a boolean flag on `reopen`.
Diffstat (limited to '')
-rw-r--r--webmentions_ssg/models.py27
1 files changed, 12 insertions, 15 deletions
diff --git a/webmentions_ssg/models.py b/webmentions_ssg/models.py
index ae2f076..dbbb7ad 100644
--- a/webmentions_ssg/models.py
+++ b/webmentions_ssg/models.py
@@ -163,11 +163,10 @@ class ReceivedWebmention(Base):
"updated_at": at,
}
- def reset_for_verification(self) -> ReceivedWebmention:
- """Reopen an existing row for manual verification and return it."""
+ def reset_for_verification(self) -> None:
+ """Reopen an existing row for manual verification."""
for key, value in self.verification_reset_values(at=datetime.now(UTC)).items():
setattr(self, key, value)
- return self
@property
def verified(self) -> bool:
@@ -299,24 +298,22 @@ class SentWebmention(Base):
"""Represent the sent Webmention by its target URL."""
return f"<SentWebmention {self.target!r}>"
- def reopen(
- self, revision: int, active: bool, *, resend: bool = False
- ) -> SentWebmention:
+ def reopen(self, revision: int, active: bool) -> None:
"""Reopen delivery for a revision while preserving send history."""
self.desired_revision = revision
self.active = active
self.attempt_count = 0
self.next_retry_at = None
- if resend:
- self.processed_revision = None
- self.status = None
- self.failure_reason = None
- self.endpoint = None
- self.response_status = None
- self.status_url = None
-
- return self
+ def resend(self) -> None:
+ """Retry the current revision, clearing its previous delivery result."""
+ self.reopen(self.desired_revision, self.active)
+ self.processed_revision = None
+ self.status = None
+ self.failure_reason = None
+ self.endpoint = None
+ self.response_status = None
+ self.status_url = None
@hybrid_property
def pending(self) -> bool: