From ca71bf1f30e118dd5bade3cff817d5bbd09f680a Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Fri, 13 Nov 2026 20:49:15 +0100 Subject: refactor(core): clarify Webmention mutation APIs Make in-place reset and reopen helpers return `None` so callers no longer perform pointless self-reassignment. Split explicit resend behavior into its own method instead of hiding it behind a boolean flag on `reopen`. --- webmentions_ssg/models.py | 27 ++++++++++++--------------- 1 file changed, 12 insertions(+), 15 deletions(-) (limited to 'webmentions_ssg/models.py') diff --git a/webmentions_ssg/models.py b/webmentions_ssg/models.py index ae2f076..dbbb7ad 100644 --- a/webmentions_ssg/models.py +++ b/webmentions_ssg/models.py @@ -163,11 +163,10 @@ class ReceivedWebmention(Base): "updated_at": at, } - def reset_for_verification(self) -> ReceivedWebmention: - """Reopen an existing row for manual verification and return it.""" + def reset_for_verification(self) -> None: + """Reopen an existing row for manual verification.""" for key, value in self.verification_reset_values(at=datetime.now(UTC)).items(): setattr(self, key, value) - return self @property def verified(self) -> bool: @@ -299,24 +298,22 @@ class SentWebmention(Base): """Represent the sent Webmention by its target URL.""" return f"" - def reopen( - self, revision: int, active: bool, *, resend: bool = False - ) -> SentWebmention: + def reopen(self, revision: int, active: bool) -> None: """Reopen delivery for a revision while preserving send history.""" self.desired_revision = revision self.active = active self.attempt_count = 0 self.next_retry_at = None - if resend: - self.processed_revision = None - self.status = None - self.failure_reason = None - self.endpoint = None - self.response_status = None - self.status_url = None - - return self + def resend(self) -> None: + """Retry the current revision, clearing its previous delivery result.""" + self.reopen(self.desired_revision, self.active) + self.processed_revision = None + self.status = None + self.failure_reason = None + self.endpoint = None + self.response_status = None + self.status_url = None @hybrid_property def pending(self) -> bool: -- cgit v1.3.1