diff options
| author | Dennis Fink | 2026-11-18 21:28:28 +0100 |
|---|---|---|
| committer | Dennis Fink | 2026-11-18 21:28:28 +0100 |
| commit | f267db9148e3a390a1a2e50fe71ac4675dceaea1 (patch) | |
| tree | 4a8490599493af811d803b575c4fcdc103d1c68b /tests/views/test_received.py | |
| parent | b2b5429bcf008db357d9d65db77ba37f7af908a8 (diff) | |
| download | webmentions-ssg-f267db9148e3a390a1a2e50fe71ac4675dceaea1.tar.gz webmentions-ssg-f267db9148e3a390a1a2e50fe71ac4675dceaea1.zip | |
refactor(core): tighten static typing
Add explicit runtime narrowing in tests and simplify Huey decorator
annotations so static analysis reflects the dynamic task wrapper
behavior.
Clean up URL argument construction and form error updates while
preserving existing application behavior.
Diffstat (limited to 'tests/views/test_received.py')
| -rw-r--r-- | tests/views/test_received.py | 39 |
1 files changed, 28 insertions, 11 deletions
diff --git a/tests/views/test_received.py b/tests/views/test_received.py index 1a291ae..ed31dc5 100644 --- a/tests/views/test_received.py +++ b/tests/views/test_received.py @@ -73,13 +73,17 @@ def test_received_table_hides_secondary_columns_on_mobile( assert len(headers) == len(cells) == 7 for index in (0, 3, 4, 5): # Select, target, received, updated for cell in (headers[index], cells[index]): - assert {"d-none", "d-md-table-cell"} <= set(cell.get("class", [])) + assert {"d-none", "d-md-table-cell"} <= set( + cell.get_attribute_list("class") + ) for index in (1, 2, 6): # Status, source, details stay visible - assert "d-none" not in cells[index].get("class", []) + assert "d-none" not in cells[index].get_attribute_list("class") assert cells[2].select_one(".d-md-none time") is not None - assert "text-break" in cells[2].get("class", []) + assert "text-break" in cells[2].get_attribute_list("class") for button in html.select("[data-received-bulk-action]"): - assert {"d-none", "d-md-inline-block"} <= set(button.get("class", [])) + assert {"d-none", "d-md-inline-block"} <= set( + button.get_attribute_list("class") + ) @pytest.mark.parametrize( @@ -837,7 +841,9 @@ def test_received_bulk_actions_reject_invalid_form( assert response.status_code == HTTPStatus.BAD_REQUEST form.validate_on_submit.assert_called_once_with() with app.app_context(): - assert db.session.get(ReceivedWebmention, identifier).status == "failed" + mention = db.session.get(ReceivedWebmention, identifier) + assert mention is not None + assert mention.status == "failed" @pytest.mark.parametrize( @@ -870,7 +876,9 @@ def test_received_bulk_actions_reject_invalid_filters_before_mutating( assert response.status_code == HTTPStatus.BAD_REQUEST with app.app_context(): - assert db.session.get(ReceivedWebmention, identifier).status == "failed" + mention = db.session.get(ReceivedWebmention, identifier) + assert mention is not None + assert mention.status == "failed" verify.assert_not_called() @@ -896,7 +904,9 @@ def test_received_bulk_actions_reject_empty_or_malformed_selection( assert response.status_code == HTTPStatus.BAD_REQUEST with app.app_context(): - assert db.session.get(ReceivedWebmention, identifier).status == "failed" + mention = db.session.get(ReceivedWebmention, identifier) + assert mention is not None + assert mention.status == "failed" verify.assert_not_called() @@ -929,7 +939,9 @@ def test_received_bulk_actions_reject_duplicate_oversized_or_stale_selection( assert oversized.status_code == HTTPStatus.BAD_REQUEST with app.app_context(): - assert db.session.get(ReceivedWebmention, first).status == "failed" + mention = db.session.get(ReceivedWebmention, first) + assert mention is not None + assert mention.status == "failed" assert db.session.get(ReceivedWebmention, second) is not None verify.assert_not_called() @@ -1001,7 +1013,9 @@ def test_reverify_selected_received_webmentions( assert webmention.status == "received" assert webmention.failure_reason is None assert webmention.recovery_attempts == 0 - assert db.session.get(ReceivedWebmention, unselected).status == "failed" + unselected_mention = db.session.get(ReceivedWebmention, unselected) + assert unselected_mention is not None + assert unselected_mention.status == "failed" assert verify.call_count == 2 assert {call.args[0] for call in verify.call_args_list} == {first, second} @@ -1264,12 +1278,15 @@ def test_received_detail_keeps_filters_and_returns_after_actions( "a", string=lambda value: bool(value and "Back to received" in value) ) assert back_link is not None - assert parse_qs(urlsplit(back_link["href"]).query) == { + back_href = back_link["href"] + assert isinstance(back_href, str) + assert parse_qs(urlsplit(back_href).query) == { key: [value] for key, value in query.items() } - action = soup.find(attrs={"data-title": "Reverify webmention?"}) + action = soup.select_one('button[data-title="Reverify webmention?"]') assert action is not None action_url = action["data-action"] + assert isinstance(action_url, str) assert parse_qs(urlsplit(action_url).query) == { **{key: [value] for key, value in query.items()}, "return_to": ["detail"], |
