diff options
| author | Dennis Fink | 2026-10-31 17:42:00 +0100 |
|---|---|---|
| committer | Dennis Fink | 2026-10-31 17:42:00 +0100 |
| commit | 6924ad7e52033365c55d5afacdd916c502cc80cb (patch) | |
| tree | 8a52b8e8fbae7a6bcc85d250cac2436a2c42e748 /tests/tasks | |
| parent | 3494eab1208dc18478485e02c61e292556502fa6 (diff) | |
| download | webmentions-ssg-6924ad7e52033365c55d5afacdd916c502cc80cb.tar.gz webmentions-ssg-6924ad7e52033365c55d5afacdd916c502cc80cb.zip | |
feat(receiver): add resource limits and retention
Bound incoming request and URL sizes so untrusted Webmention submissions
cannot consume unbounded application or database resources.
Purge old failed and deleted received Webmentions on a schedule, and use
portable SHA-256 URL fingerprints to preserve uniqueness for long URLs.
Diffstat (limited to 'tests/tasks')
| -rw-r--r-- | tests/tasks/test_consumer.py | 8 | ||||
| -rw-r--r-- | tests/tasks/test_retention.py | 69 |
2 files changed, 74 insertions, 3 deletions
diff --git a/tests/tasks/test_consumer.py b/tests/tasks/test_consumer.py index dd93331..7604691 100644 --- a/tests/tasks/test_consumer.py +++ b/tests/tasks/test_consumer.py @@ -13,7 +13,7 @@ from flask import Flask from webmentions_ssg import HUEY -def test_consumer_registers_scanner_digest_and_verification_reaper( +def test_consumer_registers_scanner_digest_reaper_and_retention( app: Flask, monkeypatch: pytest.MonkeyPatch ) -> None: import webmentions_ssg @@ -21,6 +21,7 @@ def test_consumer_registers_scanner_digest_and_verification_reaper( app.config["SCANNER_SCHEDULE"] = "*/15 * * * *" app.config["NOTIFICATION_SCHEDULE"] = "0 9 * * *" app.config["VERIFICATION_REAPER_SCHEDULE"] = "*/3 * * * *" + app.config["RECEIVED_RETENTION_SCHEDULE"] = "0 4 * * *" registered_tasks: list[object] = [] @@ -36,12 +37,13 @@ def test_consumer_registers_scanner_digest_and_verification_reaper( monkeypatch.setattr(HUEY, "periodic_task", periodic_task) consumer = importlib.import_module("webmentions_ssg.tasks.consumer") - from webmentions_ssg.tasks import notifications, receiver, scanner + from webmentions_ssg.tasks import notifications, receiver, retention, scanner assert consumer.huey is HUEY.huey - assert periodic_task.call_count == 3 + assert periodic_task.call_count == 4 assert registered_tasks == [ scanner.scan_sources, receiver.recover_stale_webmentions, notifications.send_webmention_digest, + retention.purge_old_received_webmentions, ] diff --git a/tests/tasks/test_retention.py b/tests/tasks/test_retention.py new file mode 100644 index 0000000..3f421f9 --- /dev/null +++ b/tests/tasks/test_retention.py @@ -0,0 +1,69 @@ +# SPDX-FileCopyrightText: 2026 Dennis Fink <me+coding@dennisfink.me> +# +# SPDX-License-Identifier: BSD-3-Clause + +"""Test scheduled removal of terminal received Webmentions.""" + +import uuid +from datetime import UTC, datetime, timedelta + +import sqlalchemy as sa +from flask import Flask + +from webmentions_ssg import DATABASE as db +from webmentions_ssg.models import ReceivedWebmention +from webmentions_ssg.tasks.retention import purge_old_received_webmentions + + +def test_retention_only_removes_old_failed_or_deleted_rows(app: Flask) -> None: + now = datetime.now(UTC) + app.config["RECEIVED_RETENTION_DAYS"] = 30 + identifiers = {} + with app.app_context(): + for suffix, status, age_days in ( + ("old-failed", "failed", 31), + ("old-deleted", "deleted", 31), + ("recent-failed", "failed", 2), + ("recent-deleted", "deleted", 2), + ("old-verified", "verified", 50), + ("old-received", "received", 50), + ("old-verifying", "verifying", 50), + ): + identifier = uuid.uuid7() + identifiers[suffix] = identifier + db.session.add( + ReceivedWebmention( + uuid=identifier, + source=f"https://source.example/{suffix}", + target="https://dennisfink.me/target", + status=status, + updated_at=now - timedelta(days=age_days), + ) + ) + db.session.commit() + + assert purge_old_received_webmentions() == 2 + assert purge_old_received_webmentions() == 0 + + remaining = set(db.session.scalars(sa.select(ReceivedWebmention.uuid))) + assert remaining == { + identifier + for key, identifier in identifiers.items() + if key not in {"old-failed", "old-deleted"} + } + + +def test_retention_uses_admin_configured_days(app: Flask) -> None: + app.config["RECEIVED_RETENTION_DAYS"] = 7 + with app.app_context(): + db.session.add( + ReceivedWebmention( + uuid=uuid.uuid7(), + source="https://source.example/one", + target="https://dennisfink.me/target", + status="failed", + updated_at=datetime.now(UTC) - timedelta(days=10), + ) + ) + db.session.commit() + assert purge_old_received_webmentions() == 1 |
