1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
|
# SPDX-FileCopyrightText: 2026 Dennis Fink <me+coding@dennisfink.me>
#
# SPDX-License-Identifier: BSD-3-Clause
from unittest.mock import patch
import pytest
import sqlalchemy as sa
from flask import Flask
from webmentions_ssg import DATABASE
from webmentions_ssg.models import User
def _add_user(app: Flask, username: str, password: str = "original") -> None:
"""Persist a user using the same model as the CLI."""
with app.app_context():
DATABASE.session.add(User(username=username, password=password))
DATABASE.session.commit()
def _get_user(app: Flask, username: str) -> User | None:
with app.app_context():
return DATABASE.session.scalar(sa.select(User).where(User.username == username))
def test_users_cli_help_lists_management_commands(app: Flask) -> None:
result = app.test_cli_runner().invoke(args=["users", "--help"])
assert result.exit_code == 0, result.output
for command in ("create", "list", "set-password", "delete"):
assert command in result.output
def test_users_cli_create_with_prompts_hashes_password(app: Flask) -> None:
result = app.test_cli_runner().invoke(
args=["users", "create"], input="alice\nnew-secret\nnew-secret\n"
)
assert result.exit_code == 0, result.output
assert "Created user 'alice'." in result.output
assert "new-secret" not in result.output
user = _get_user(app, "alice")
assert user is not None
assert user.check_password("new-secret")
assert user.password_hash != "new-secret"
def test_users_cli_create_with_username_option(app: Flask) -> None:
result = app.test_cli_runner().invoke(
args=["users", "create", "--username", "alice"],
input="new-secret\nnew-secret\n",
)
assert result.exit_code == 0, result.output
assert _get_user(app, "alice") is not None
def test_users_cli_create_rejects_duplicate(app: Flask) -> None:
_add_user(app, "alice")
result = app.test_cli_runner().invoke(
args=["users", "create", "--username", "alice", "--password", "other"]
)
assert result.exit_code != 0
assert "User 'alice' already exists." in result.output
user = _get_user(app, "alice")
assert user is not None
assert user.check_password("original")
@pytest.mark.parametrize("username", ["", " "])
def test_users_cli_create_rejects_invalid_username(app: Flask, username: str) -> None:
result = app.test_cli_runner().invoke(
args=["users", "create", "--username", username, "--password", "valid"]
)
assert result.exit_code != 0
assert "Username must not" in result.output
def test_users_cli_create_rejects_empty_password(app: Flask) -> None:
result = app.test_cli_runner().invoke(
args=["users", "create", "--username", "alice", "--password", ""]
)
assert result.exit_code != 0
assert "Password must not be empty." in result.output
assert _get_user(app, "alice") is None
def test_users_cli_list_empty(app: Flask) -> None:
result = app.test_cli_runner().invoke(args=["users", "list"])
assert result.exit_code == 0, result.output
assert "No users found." in result.output
def test_users_cli_list_is_sorted_and_excludes_passwords(app: Flask) -> None:
_add_user(app, "zoe")
_add_user(app, "alice")
result = app.test_cli_runner().invoke(args=["users", "list"])
assert result.exit_code == 0, result.output
lines = result.output.splitlines()
assert lines[0] == "ID\tUSERNAME"
assert lines[1].endswith("\talice")
assert lines[2].endswith("\tzoe")
assert "original" not in result.output
def test_users_cli_set_password_updates_hash(app: Flask) -> None:
_add_user(app, "alice")
old_hash = _get_user(app, "alice").password_hash # type: ignore[union-attr]
result = app.test_cli_runner().invoke(
args=["users", "set-password", "alice"], input="replacement\nreplacement\n"
)
assert result.exit_code == 0, result.output
assert "Updated password for user 'alice'." in result.output
assert "replacement" not in result.output
user = _get_user(app, "alice")
assert user is not None
assert user.password_hash != old_hash
assert not user.check_password("original")
assert user.check_password("replacement")
def test_users_cli_set_password_missing_user(app: Flask) -> None:
result = app.test_cli_runner().invoke(
args=["users", "set-password", "missing", "--password", "replacement"]
)
assert result.exit_code != 0
assert "User 'missing' does not exist." in result.output
def test_users_cli_set_password_rejects_empty_password(app: Flask) -> None:
_add_user(app, "alice")
result = app.test_cli_runner().invoke(
args=["users", "set-password", "alice", "--password", ""]
)
assert result.exit_code != 0
assert "Password must not be empty." in result.output
user = _get_user(app, "alice")
assert user is not None
assert user.check_password("original")
def test_users_cli_delete_with_confirmation(app: Flask) -> None:
_add_user(app, "alice")
result = app.test_cli_runner().invoke(
args=["users", "delete", "alice"], input="y\n"
)
assert result.exit_code == 0, result.output
assert "Delete user 'alice'?" in result.output
assert "Deleted user 'alice'." in result.output
assert _get_user(app, "alice") is None
def test_users_cli_delete_confirmation_rejected(app: Flask) -> None:
_add_user(app, "alice")
result = app.test_cli_runner().invoke(
args=["users", "delete", "alice"], input="n\n"
)
assert result.exit_code != 0
assert "Aborted" in result.output
assert _get_user(app, "alice") is not None
def test_users_cli_delete_yes_only_deletes_target(app: Flask) -> None:
_add_user(app, "alice")
_add_user(app, "bob")
result = app.test_cli_runner().invoke(args=["users", "delete", "alice", "--yes"])
assert result.exit_code == 0, result.output
assert "Deleted user 'alice'." in result.output
assert _get_user(app, "alice") is None
assert _get_user(app, "bob") is not None
def test_users_cli_delete_missing_user(app: Flask) -> None:
result = app.test_cli_runner().invoke(args=["users", "delete", "missing", "-y"])
assert result.exit_code != 0
assert "User 'missing' does not exist." in result.output
def test_users_cli_delete_missing_blank_username(app: Flask) -> None:
result = app.test_cli_runner().invoke(args=["users", "delete", " ", "--yes"])
assert result.exit_code != 0
assert "User ' ' does not exist." in result.output
def test_users_cli_can_manage_legacy_whitespace_username(app: Flask) -> None:
_add_user(app, " alice ")
reset = app.test_cli_runner().invoke(
args=["users", "set-password", " alice ", "--password", "replacement"]
)
assert reset.exit_code == 0, reset.output
user = _get_user(app, " alice ")
assert user is not None
assert user.check_password("replacement")
deleted = app.test_cli_runner().invoke(args=["users", "delete", " alice ", "--yes"])
assert deleted.exit_code == 0, deleted.output
assert _get_user(app, " alice ") is None
def test_users_cli_create_rolls_back_on_duplicate_race(app: Flask) -> None:
database_error = sa.exc.IntegrityError("INSERT", {}, Exception("duplicate"))
with app.app_context():
with (
patch.object(DATABASE.session, "commit", side_effect=database_error),
patch.object(DATABASE.session, "rollback") as rollback,
):
result = app.test_cli_runner().invoke(
args=["users", "create", "--username", "alice", "--password", "secret"]
)
rollback.assert_called_once()
assert result.exit_code != 0
assert "User 'alice' already exists." in result.output
|