From 22f453be12822f1c26f2ba6e229cdc8840ffaa92 Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Fri, 13 Nov 2026 20:26:18 +0100 Subject: refactor(core): remove redundant abort returns Call Flask `abort` directly in view guards since it always raises and never returns, simplifying error branches without changing response behavior. --- webmentions_ssg/views/admin.py | 14 +++++++------- webmentions_ssg/views/endpoint.py | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'webmentions_ssg') diff --git a/webmentions_ssg/views/admin.py b/webmentions_ssg/views/admin.py index e7c5325..461d329 100644 --- a/webmentions_ssg/views/admin.py +++ b/webmentions_ssg/views/admin.py @@ -52,12 +52,12 @@ def delete_received_webmention(identifier: uuid.UUID) -> ResponseReturnValue: form = forms.AdminActionForm() if not form.validate_on_submit(): - return abort(400) + abort(400) webmention = db.session.get(ReceivedWebmention, identifier) if webmention is None: - return abort(404) + abort(404) db.session.delete(webmention) db.session.commit() @@ -82,12 +82,12 @@ def reverify_received_webmention(identifier: uuid.UUID) -> ResponseReturnValue: form = forms.AdminActionForm() if not form.validate_on_submit(): - return abort(400) + abort(400) webmention = db.session.get(ReceivedWebmention, identifier) if webmention is None: - return abort(404) + abort(404) webmention = webmention.reset_for_verification() @@ -150,7 +150,7 @@ def sent_source(source_identifier: uuid.UUID) -> ResponseReturnValue: ) if source is None: - return abort(404) + abort(404) webmentions = db.paginate( sa.select(SentWebmention) @@ -187,12 +187,12 @@ def resend_sent_webmention( form = forms.AdminActionForm() if not form.validate_on_submit(): - return abort(400) + abort(400) webmention = db.session.get(SentWebmention, webmention_identifier) if webmention is None or webmention.source_id != source_identifier: - return abort(404) + abort(404) # Reopen the existing desired revision instead of inventing a new source # revision. send_webmention() otherwise exits when this revision has already diff --git a/webmentions_ssg/views/endpoint.py b/webmentions_ssg/views/endpoint.py index a94310e..e3f1368 100644 --- a/webmentions_ssg/views/endpoint.py +++ b/webmentions_ssg/views/endpoint.py @@ -147,7 +147,7 @@ def status(identifier: uuid.UUID) -> ResponseReturnValue: webmention = db.session.get(ReceivedWebmention, identifier) if webmention is None: - return abort(404) + abort(404) return render_template( "status.html", title="Webmention status", webmention=webmention -- cgit v1.3.1