From f267db9148e3a390a1a2e50fe71ac4675dceaea1 Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Wed, 18 Nov 2026 21:28:28 +0100 Subject: refactor(core): tighten static typing Add explicit runtime narrowing in tests and simplify Huey decorator annotations so static analysis reflects the dynamic task wrapper behavior. Clean up URL argument construction and form error updates while preserving existing application behavior. --- webmentions_ssg/views/sources.py | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) (limited to 'webmentions_ssg/views/sources.py') diff --git a/webmentions_ssg/views/sources.py b/webmentions_ssg/views/sources.py index 1c9cc58..84b98fb 100644 --- a/webmentions_ssg/views/sources.py +++ b/webmentions_ssg/views/sources.py @@ -183,11 +183,10 @@ def rescan_sources() -> ResponseReturnValue: manual_scan_sources() flash("Source rescan queued.", "success") - query_args: dict[str, str | int] = dict(filters) page = request.args.get("page", 1, type=int) - if page > 1: - query_args["page"] = page - return redirect(url_for("webmentions.source_list", **query_args)) + return redirect( + url_for("webmentions.source_list", page=page if page > 1 else None, **filters) + ) @webmentions_bp.route("/sources/") @@ -256,11 +255,14 @@ def resend_webmention( flash(f"Webmention {webmention.uuid} queued for resend.", "success") - detail_args: dict[str, str | int] = dict(filters) - for name in ("page", "source_page"): - page = request.args.get(name, 1, type=int) - if page > 1: - detail_args[name] = page + page = request.args.get("page", 1, type=int) + source_page = request.args.get("source_page", 1, type=int) return redirect( - url_for("webmentions.source_detail", source_uuid=source_uuid, **detail_args) + url_for( + "webmentions.source_detail", + source_uuid=source_uuid, + page=page if page > 1 else None, + source_page=source_page if source_page > 1 else None, + **filters, + ) ) -- cgit v1.3.1