From ca71bf1f30e118dd5bade3cff817d5bbd09f680a Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Fri, 13 Nov 2026 20:49:15 +0100 Subject: refactor(core): clarify Webmention mutation APIs Make in-place reset and reopen helpers return `None` so callers no longer perform pointless self-reassignment. Split explicit resend behavior into its own method instead of hiding it behind a boolean flag on `reopen`. --- webmentions_ssg/views/admin.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'webmentions_ssg/views/admin.py') diff --git a/webmentions_ssg/views/admin.py b/webmentions_ssg/views/admin.py index 461d329..1ca06b5 100644 --- a/webmentions_ssg/views/admin.py +++ b/webmentions_ssg/views/admin.py @@ -89,7 +89,7 @@ def reverify_received_webmention(identifier: uuid.UUID) -> ResponseReturnValue: if webmention is None: abort(404) - webmention = webmention.reset_for_verification() + webmention.reset_for_verification() db.session.commit() @@ -194,12 +194,10 @@ def resend_sent_webmention( if webmention is None or webmention.source_id != source_identifier: abort(404) - # Reopen the existing desired revision instead of inventing a new source + # Requeue the existing desired revision instead of inventing a new source # revision. send_webmention() otherwise exits when this revision has already # been processed. - webmention = webmention.reopen( - webmention.desired_revision, webmention.active, resend=True - ) + webmention.resend() db.session.commit() -- cgit v1.3.1