From b0f3eeb78bcf601982d04f3aa595ab8942de417f Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Fri, 13 Nov 2026 21:27:28 +0100 Subject: fix(core): reject invalid admin action forms Centralize administrative form validation so all protected actions return HTTP 400 on invalid submissions instead of allowing the rescan action to fail silently. --- webmentions_ssg/views/admin.py | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) (limited to 'webmentions_ssg/views/admin.py') diff --git a/webmentions_ssg/views/admin.py b/webmentions_ssg/views/admin.py index 794bcdf..f095de8 100644 --- a/webmentions_ssg/views/admin.py +++ b/webmentions_ssg/views/admin.py @@ -21,6 +21,12 @@ from ..tasks.sender import send_webmention from .blueprint import root_page +def validate_admin_action() -> None: + """Reject invalid administrative action forms with HTTP 400.""" + if not forms.AdminActionForm().validate_on_submit(): + abort(400) + + @root_page.route("/received") @login_required def received() -> ResponseReturnValue: @@ -49,10 +55,7 @@ def delete_received_webmention(identifier: uuid.UUID) -> ResponseReturnValue: :param identifier: Identifier of the Webmention to delete. :return: Redirect response to the received Webmentions view. """ - form = forms.AdminActionForm() - - if not form.validate_on_submit(): - abort(400) + validate_admin_action() webmention = db.get_or_404(ReceivedWebmention, identifier) @@ -76,10 +79,7 @@ def reverify_received_webmention(identifier: uuid.UUID) -> ResponseReturnValue: :param identifier: Identifier of the Webmention to reverify. :return: Redirect response to the received Webmentions view. """ - form = forms.AdminActionForm() - - if not form.validate_on_submit(): - abort(400) + validate_admin_action() webmention = db.get_or_404(ReceivedWebmention, identifier) @@ -124,10 +124,11 @@ def rescan_sent_sources() -> ResponseReturnValue: :return: Redirect response to the sent Webmentions view. """ - form = forms.AdminActionForm() - if form.validate_on_submit(): - manual_scan_sources() - flash("Source rescan queued.", "success") + validate_admin_action() + + manual_scan_sources() + flash("Source rescan queued.", "success") + return redirect(url_for("root.sent")) @@ -173,10 +174,7 @@ def resend_sent_webmention( :param webmention_identifier: Identifier of the sent Webmention to resend. :return: Redirect response to the source details view. """ - form = forms.AdminActionForm() - - if not form.validate_on_submit(): - abort(400) + validate_admin_action() webmention = db.get_or_404(SentWebmention, webmention_identifier) -- cgit v1.3.1