From 8b6326f070c941510ebf1d27e53f501610406ea4 Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Fri, 13 Nov 2026 20:23:13 +0100 Subject: refactor(core): replace HTTP status magic numbers Use `HTTPStatus` constants for standard response codes and a named upper bound for retryable server errors so network and task status handling is self-documenting. --- webmentions_ssg/tasks/discovery.py | 3 ++- webmentions_ssg/tasks/receiver.py | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) (limited to 'webmentions_ssg/tasks') diff --git a/webmentions_ssg/tasks/discovery.py b/webmentions_ssg/tasks/discovery.py index 456e47e..107d30a 100644 --- a/webmentions_ssg/tasks/discovery.py +++ b/webmentions_ssg/tasks/discovery.py @@ -5,6 +5,7 @@ """Discover a target Webmention endpoint and submit a POST.""" import re +from http import HTTPStatus from urllib.parse import urljoin import httpx @@ -198,7 +199,7 @@ def post_webmention( ) as response: status_url = None - if response.status_code == 201 and ( + if response.status_code == HTTPStatus.CREATED and ( location := response.headers.get("Location") ): try: diff --git a/webmentions_ssg/tasks/receiver.py b/webmentions_ssg/tasks/receiver.py index cbb42b6..78089af 100644 --- a/webmentions_ssg/tasks/receiver.py +++ b/webmentions_ssg/tasks/receiver.py @@ -6,6 +6,7 @@ import uuid from datetime import UTC, datetime, timedelta +from http import HTTPStatus from typing import Any, cast import httpx @@ -62,9 +63,9 @@ def fetch_source(source_url: str) -> tuple[httpx.Response, bytes]: ) as client, client.stream("GET", source_url) as response, ): - if response.status_code == 200: + if response.status_code == HTTPStatus.OK: pass - elif response.status_code == 410: + elif response.status_code == HTTPStatus.GONE: raise SourceGoneError("Source returned HTTP 410") elif is_temporary_status(response.status_code): raise TemporaryFetchError( -- cgit v1.3.1