From 6924ad7e52033365c55d5afacdd916c502cc80cb Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Sat, 31 Oct 2026 17:42:00 +0100 Subject: feat(receiver): add resource limits and retention Bound incoming request and URL sizes so untrusted Webmention submissions cannot consume unbounded application or database resources. Purge old failed and deleted received Webmentions on a schedule, and use portable SHA-256 URL fingerprints to preserve uniqueness for long URLs. --- webmentions_ssg/tasks/consumer.py | 7 ++++++- webmentions_ssg/tasks/retention.py | 41 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+), 1 deletion(-) create mode 100644 webmentions_ssg/tasks/retention.py (limited to 'webmentions_ssg/tasks') diff --git a/webmentions_ssg/tasks/consumer.py b/webmentions_ssg/tasks/consumer.py index afae6e0..fb1d46d 100644 --- a/webmentions_ssg/tasks/consumer.py +++ b/webmentions_ssg/tasks/consumer.py @@ -21,7 +21,7 @@ def create_consumer() -> Huey: """ app = create_app() - from . import notifications, receiver, scanner, sender # noqa: F401 + from . import notifications, receiver, retention, scanner, sender # noqa: F401 schedule = crontab(*app.config["SCANNER_SCHEDULE"].split(), strict=True) HUEY.periodic_task(schedule)(scanner.scan_sources) @@ -36,6 +36,11 @@ def create_consumer() -> Huey: ) HUEY.periodic_task(notification_schedule)(notifications.send_webmention_digest) + retention_schedule = crontab( + *app.config["RECEIVED_RETENTION_SCHEDULE"].split(), strict=True + ) + HUEY.periodic_task(retention_schedule)(retention.purge_old_received_webmentions) + return HUEY.huey diff --git a/webmentions_ssg/tasks/retention.py b/webmentions_ssg/tasks/retention.py new file mode 100644 index 0000000..727b186 --- /dev/null +++ b/webmentions_ssg/tasks/retention.py @@ -0,0 +1,41 @@ +# SPDX-FileCopyrightText: 2026 Dennis Fink +# +# SPDX-License-Identifier: BSD-3-Clause + +"""Delete old received Webmentions in terminal unsuccessful states.""" + +from datetime import UTC, datetime, timedelta +from typing import Any, cast + +import sqlalchemy as sa +from flask import current_app +from sqlalchemy.engine import CursorResult + +from .. import DATABASE as db +from ..models import ReceivedWebmention + + +def purge_old_received_webmentions() -> int: + """Delete old failed/deleted received rows, retaining verified and in-flight ones. + + The status/time predicate is checked by the database in one DELETE, so a + row recently requeued for verification is not purged based on a stale read. + Outgoing sources and Webmentions are intentionally unaffected. + """ + cutoff = datetime.now(UTC) - timedelta( + days=current_app.config["RECEIVED_RETENTION_DAYS"] + ) + result = cast( + CursorResult[Any], + db.session.execute( + sa.delete(ReceivedWebmention).where( + ReceivedWebmention.status.in_(("failed", "deleted")), + ReceivedWebmention.updated_at < cutoff, + ) + ), + ) + db.session.commit() + removed = result.rowcount + if removed: + current_app.logger.info("Purged %d old failed/deleted Webmentions", removed) + return removed -- cgit v1.3.1