From 53370723df05193938ce3c2d55a8e12f2a87b17b Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Fri, 30 Oct 2026 20:41:25 +0100 Subject: fix(core): replace Huey pickle serialization with JSON Prevent broker-controlled task and result payloads from deserializing arbitrary Python objects by using a restricted JSON serializer with an explicit type allowlist. Fail closed on serializer overrides and document broker isolation and migration requirements for existing pickle-backed deployments. --- webmentions_ssg/tasks/extension.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'webmentions_ssg/tasks/extension.py') diff --git a/webmentions_ssg/tasks/extension.py b/webmentions_ssg/tasks/extension.py index 79d7df9..df6cb21 100644 --- a/webmentions_ssg/tasks/extension.py +++ b/webmentions_ssg/tasks/extension.py @@ -13,6 +13,8 @@ from flask import Flask from huey import Huey as BaseHuey from huey.api import TaskWrapper +from .json_serializer import JSONSerializer + P = ParamSpec("P") R = TypeVar("R") @@ -57,6 +59,17 @@ class Huey: **app.config.get("HUEY", {}), } + # An arbitrary serializer supplied via HUEY would silently restore + # pickle deserialization of broker-controlled bytes. Fail closed. + if "serializer" in config: + raise RuntimeError( + "HUEY.serializer cannot be overridden; JSON is required." + ) + config["serializer"] = JSONSerializer( + compression=config.pop("compression", False), + use_zlib=config.pop("use_zlib", False), + ) + url = app.config.get("HUEY_URL", config.pop("url", "memory://")) huey_class, storage_kwargs = self.backend_from_url(url) -- cgit v1.3.1