From 5c1eb15f00e20ece0a4ff8e7e1b4a5ab51e54232 Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Fri, 13 Nov 2026 19:22:33 +0100 Subject: refactor(core): simplify login password verification Replace the module-level dummy user with a lazily cached password hash so unknown usernames still perform a password check without hashing during every import. Use one linear verification path for existing, missing, and empty passwords. --- webmentions_ssg/auth.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'webmentions_ssg/auth.py') diff --git a/webmentions_ssg/auth.py b/webmentions_ssg/auth.py index 6d4fe95..edfc858 100644 --- a/webmentions_ssg/auth.py +++ b/webmentions_ssg/auth.py @@ -6,12 +6,14 @@ import hashlib import secrets +from functools import cache from hmac import compare_digest from urllib.parse import urlsplit from flask import request from flask_limiter.util import get_remote_address from flask_login import LoginManager +from werkzeug.security import generate_password_hash from .extensions import db from .models import User @@ -23,8 +25,11 @@ AUTH.login_view = "root.login" # pyright: ignore[reportAttributeAccessIssue] MIN_PASSWORD_LENGTH = 8 -DUMMY_USER = User(username=secrets.token_urlsafe()) -DUMMY_USER.password = secrets.token_urlsafe() + +@cache +def dummy_password_hash() -> str: + """Lazily generate a reusable hash for unknown login usernames.""" + return generate_password_hash(secrets.token_urlsafe()) def validate_password(password: str) -> None: -- cgit v1.3.1