From eb11fb64e9cad6fbda2065362189653416d98577 Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Thu, 19 Nov 2026 21:18:37 +0100 Subject: test: expand failure and migration coverage Add regression coverage for malformed input, lost task claims, moderation races, network failures, serializer validation, and production configuration guards. Exercise migration downgrade, backfill, and autogeneration paths plus additional receiver and sender edge cases. --- tests/views/test_moderation.py | 76 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 76 insertions(+) (limited to 'tests/views/test_moderation.py') diff --git a/tests/views/test_moderation.py b/tests/views/test_moderation.py index 78ff661..92446c4 100644 --- a/tests/views/test_moderation.py +++ b/tests/views/test_moderation.py @@ -276,3 +276,79 @@ def test_admin_actions_enforce_csrf(app: Flask, client: FlaskClient) -> None: ).status_code == HTTPStatus.BAD_REQUEST ) + + +def test_block_domains_survives_unique_constraint_race( + app: Flask, monkeypatch: pytest.MonkeyPatch +) -> None: + from sqlalchemy.exc import IntegrityError + + from webmentions_ssg.views.moderation import block_domains + + with app.app_context(): + session = db.session() + real_flush = session.flush + + def simulated_concurrent_insert(*args: object, **kwargs: object) -> None: + if any( + isinstance(obj, BlockedDomain) and obj.domain == "a-loser.example" + for obj in session.new + ): + raise IntegrityError("duplicate", {}, Exception("concurrent insert")) + real_flush(*args, **kwargs) + + with monkeypatch.context() as patcher: + patcher.setattr(session, "flush", simulated_concurrent_insert) + assert block_domains({"a-loser.example", "b-winner.example"}) == 1 + + assert set(db.session.scalars(sa.select(BlockedDomain.domain))) == { + "b-winner.example" + } + + +def test_moderation_add_recovers_from_duplicate_insert_race( + app: Flask, client: FlaskClient, monkeypatch: pytest.MonkeyPatch +) -> None: + from sqlalchemy.exc import IntegrityError + + log_in(app, client) + commit = Mock(side_effect=IntegrityError("duplicate", {}, Exception("race"))) + rollback = Mock(wraps=db.session.rollback) + with monkeypatch.context() as patcher: + patcher.setattr(db.session, "commit", commit) + patcher.setattr(db.session, "rollback", rollback) + response = client.post( + "/moderation/blocked/add", data={"domain": "racing.example"} + ) + + assert response.status_code == HTTPStatus.FOUND + assert response.headers["Location"].endswith("/moderation") + commit.assert_called_once() + rollback.assert_called_once() + + +@pytest.mark.parametrize("kind", ["invalid", "blocked"]) +def test_moderation_delete_rejects_bad_kind_or_invalid_form( + app: Flask, + client: FlaskClient, + monkeypatch: pytest.MonkeyPatch, + kind: str, +) -> None: + from webmentions_ssg.views import moderation + + log_in(app, client) + form = Mock() + form.validate_on_submit.return_value = False + monkeypatch.setattr(moderation, "ConfirmActionForm", Mock(return_value=form)) + with app.app_context(): + entry = BlockedDomain(domain="example.test") + db.session.add(entry) + db.session.commit() + entry_id = entry.id + + response = client.post(f"/moderation/{kind}/{entry_id}/delete") + assert response.status_code == ( + HTTPStatus.NOT_FOUND if kind == "invalid" else HTTPStatus.BAD_REQUEST + ) + with app.app_context(): + assert db.session.get(BlockedDomain, entry_id) is not None -- cgit v1.3.1