From df3b79e2c89978ec21dc2da7f90801dce33aeab2 Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Sat, 31 Oct 2026 19:00:17 +0100 Subject: fix(receiver): prevent endless verification recovery Cap stale verification requeues so repeatedly lost or crashing tasks eventually become terminal failures instead of cycling indefinitely. Reject URLs that httpx cannot safely fetch before enqueueing, and persist unexpected verification errors as terminal failures. --- tests/test_views.py | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) (limited to 'tests/test_views.py') diff --git a/tests/test_views.py b/tests/test_views.py index f5e301f..2108b38 100644 --- a/tests/test_views.py +++ b/tests/test_views.py @@ -576,6 +576,11 @@ def test_reverify_received_webmention( identifier = create_received_webmention( app, status="failed", failure_reason="Previous failure" ) + with app.app_context(): + row = db.session.get(ReceivedWebmention, identifier) + assert row is not None + row.recovery_attempts = 3 + db.session.commit() mock_admin_action_form(views_module, monkeypatch, valid=True) verify_webmention = Mock() monkeypatch.setattr(views_module, "verify_webmention", verify_webmention) @@ -590,6 +595,7 @@ def test_reverify_received_webmention( assert webmention is not None assert webmention.status == "received" assert webmention.failure_reason is None + assert webmention.recovery_attempts == 0 verify_webmention.assert_called_once_with(identifier) @@ -911,6 +917,7 @@ def test_endpoint_reverifies_after_cooldown( target=TARGET_URL, status="failed", failure_reason="Previous failure", + recovery_attempts=3, updated_at=datetime.now(UTC) - timedelta(minutes=11), ) db.session.add(webmention) @@ -926,6 +933,7 @@ def test_endpoint_reverifies_after_cooldown( assert stored is not None assert stored.status == "received" assert stored.failure_reason is None + assert stored.recovery_attempts == 0 verify.assert_called_once_with(identifier) @@ -1194,3 +1202,27 @@ def test_endpoint_rejects_request_bodies_over_configured_maximum( "/endpoint", data={"source": SOURCE_URL + "x" * 150, "target": TARGET_URL} ) assert response.status_code == 413 + + +def test_endpoint_rejects_bad_url_before_inserting_row( + app: Flask, client: FlaskClient, monkeypatch: pytest.MonkeyPatch +) -> None: + from webmentions_ssg import views + + verify_webmention = Mock() + monkeypatch.setattr(views, "verify_webmention", verify_webmention) + + response = client.post( + "/endpoint", data={"source": "http://ex☃mple.test/", "target": TARGET_URL} + ) + + assert response.status_code == 400 + assert "source" in response.get_json() + verify_webmention.assert_not_called() + with app.app_context(): + assert ( + db.session.scalar( + sa.select(sa.func.count()).select_from(ReceivedWebmention) + ) + == 0 + ) -- cgit v1.3.1