From 4485aeb573ceb37237ea1fbc80665ed6c4136116 Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Fri, 30 Oct 2026 08:35:46 +0100 Subject: fix(core): harden application configuration Fail production startup when required configuration is missing, normalize allowed hostnames before validation, and move shared request limits into the default configuration so production does not depend on testing-only values. Set secure session cookie defaults while preserving explicit overrides and document the new rate-limit and notification settings in the example config. --- tests/test_config.py | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 tests/test_config.py (limited to 'tests/test_config.py') diff --git a/tests/test_config.py b/tests/test_config.py new file mode 100644 index 0000000..8d5aa5b --- /dev/null +++ b/tests/test_config.py @@ -0,0 +1,45 @@ +# SPDX-FileCopyrightText: 2026 Dennis Fink +# +# SPDX-License-Identifier: BSD-3-Clause + +"""Test built-in session cookie defaults and explicit overrides.""" + +import pytest + +from webmentions_ssg import create_app +from webmentions_ssg.config import ( + DefaultConfig, + DevelopmentConfig, + ProductionConfig, + TestingConfig, +) + + +@pytest.mark.parametrize( + ("config_class", "expected_secure"), + [ + (DefaultConfig, True), + (ProductionConfig, True), + (DevelopmentConfig, False), + (TestingConfig, False), + ], +) +def test_session_cookie_defaults( + config_class: type[DefaultConfig], expected_secure: bool +) -> None: + assert config_class.SESSION_COOKIE_SECURE is expected_secure + assert config_class.SESSION_COOKIE_HTTPONLY is True + assert config_class.SESSION_COOKIE_SAMESITE == "Lax" + + +def test_explicit_config_overrides_session_cookie_defaults() -> None: + class CookieOverrideConfig(TestingConfig): + SESSION_COOKIE_SECURE = True + SESSION_COOKIE_HTTPONLY = False + SESSION_COOKIE_SAMESITE = "Strict" + + app = create_app(CookieOverrideConfig) + + assert app.config["SESSION_COOKIE_SECURE"] is True + assert app.config["SESSION_COOKIE_HTTPONLY"] is False + assert app.config["SESSION_COOKIE_SAMESITE"] == "Strict" -- cgit v1.3.1