From c74feda222745ab7cca8993df83d9ea5f9d07e5b Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Sat, 14 Nov 2026 19:43:28 +0100 Subject: refactor(core): use HTTPStatus consistently Replace numeric HTTP response and assertion codes in views and tests with `HTTPStatus` members so status handling is more descriptive and consistent. --- tests/test_auth.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'tests/test_auth.py') diff --git a/tests/test_auth.py b/tests/test_auth.py index bc951b9..3b05b6f 100644 --- a/tests/test_auth.py +++ b/tests/test_auth.py @@ -4,6 +4,8 @@ """Test the session user loader.""" +from http import HTTPStatus + import pytest from flask import Flask @@ -94,8 +96,8 @@ def test_password_change_invalidates_existing_session(app: Flask) -> None: response = client.post( "/login", data={"username": "account", "password": old_password} ) - assert response.status_code == 302 - assert client.get("/received").status_code == 200 + assert response.status_code == HTTPStatus.FOUND + assert client.get("/received").status_code == HTTPStatus.OK with client.session_transaction() as session: assert session["_user_id"] == old_identifier @@ -113,14 +115,14 @@ def test_password_change_invalidates_existing_session(app: Flask) -> None: assert load_user(user.get_id()) is user # A pre-existing, validly signed cookie no longer authenticates. - assert client.get("/received").status_code == 302 + assert client.get("/received").status_code == HTTPStatus.FOUND # Logging in with the newly chosen password still works. response = client.post( "/login", data={"username": "account", "password": new_password} ) - assert response.status_code == 302 - assert client.get("/received").status_code == 200 + assert response.status_code == HTTPStatus.FOUND + assert client.get("/received").status_code == HTTPStatus.OK @pytest.mark.parametrize( -- cgit v1.3.1