From edd7c0c2220ba12c2a773f9ba1cf6e0e7a273856 Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Thu, 29 Oct 2026 20:59:48 +0100 Subject: feat(receiver): send Webmention notification digests Batch verified Webmention notifications into a scheduled digest so bursts of incoming mentions do not generate a separate email for every verification. Track which mentions have already been reported and leave them pending when SMTP delivery fails so a later digest can retry safely. --- tests/tasks/test_receiver.py | 45 ++------------------------------------------ 1 file changed, 2 insertions(+), 43 deletions(-) (limited to 'tests/tasks/test_receiver.py') diff --git a/tests/tasks/test_receiver.py b/tests/tasks/test_receiver.py index f4ab09f..1943b65 100644 --- a/tests/tasks/test_receiver.py +++ b/tests/tasks/test_receiver.py @@ -468,18 +468,10 @@ def test_verify_webmention_persists_final_state( ) case _: raise AssertionError(f"Unexpected outcome: {outcome}") - - app.config["NOTIFICATION_EMAIL"] = "owner@example.com" - - with patch.object(receiver, "send_webmention_notification") as enqueue: - receiver.verify_webmention.call_local(identifier) + receiver.verify_webmention.call_local(identifier) assert get_webmention_state(app, identifier) == (expected_status, expected_reason) - # The receiver always enqueues when requested; the notification task - # checks the persisted status before deciding whether to send an email. - enqueue.assert_called_once_with(identifier) - @patch("webmentions_ssg.tasks.receiver.source_mentions_target") @pytest.mark.parametrize("failure", ["temporary-http", "network"]) @@ -500,16 +492,10 @@ def test_verify_webmention_persists_retryable_failure_and_reraises( source_mentions_target.side_effect = exception - app.config["NOTIFICATION_EMAIL"] = "owner@example.com" - - with ( - patch.object(receiver, "send_webmention_notification") as enqueue, - pytest.raises(type(exception), match=str(exception)), - ): + with pytest.raises(type(exception), match=str(exception)): receiver.verify_webmention.call_local(identifier) assert get_webmention_state(app, identifier) == ("failed", str(exception)) - enqueue.assert_not_called() def test_verify_webmention_ignores_unknown_identifier( @@ -621,30 +607,3 @@ def test_source_mentions_target_falls_back_for_unknown_encoding( assert receiver.source_mentions_target(SOURCE_URL, TARGET_URL) fetch_source.assert_called_once_with(SOURCE_URL) - - -@patch("webmentions_ssg.tasks.receiver.source_mentions_target", return_value=True) -def test_verify_webmention_keeps_verified_state_when_notification_enqueue_fails( - source_mentions_target: Mock, - app: Flask, - receiver: ModuleType, - caplog: pytest.LogCaptureFixture, -) -> None: - identifier = create_webmention(app) - - with ( - patch.object( - receiver, - "send_webmention_notification", - side_effect=RuntimeError("Huey unavailable"), - ) as enqueue, - caplog.at_level(logging.ERROR), - ): - # Enqueueing fails, but verification must return without raising. - receiver.verify_webmention.call_local(identifier) - - source_mentions_target.assert_called_once_with(SOURCE_URL, TARGET_URL) - enqueue.assert_called_once_with(identifier) - assert get_webmention_state(app, identifier) == ("verified", None) - assert f"Could not enqueue webmention notification for {identifier}" in caplog.text - assert "RuntimeError: Huey unavailable" in caplog.text -- cgit v1.3.1