From 87117345ed6e99e5a070d919ac17139cba7b8fe4 Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Fri, 13 Nov 2026 20:03:49 +0100 Subject: fix(core): make network task failures explicit Introduce a dedicated response-size error so callers only translate expected limit violations instead of masking unrelated `ValueError` exceptions. Ensure failed sockets are always closed, remove dead discovery error handling, and log unexpected sender failures with tracebacks before recording them. --- tests/tasks/test_discovery.py | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) (limited to 'tests/tasks/test_discovery.py') diff --git a/tests/tasks/test_discovery.py b/tests/tasks/test_discovery.py index 2d6c37e..7c28108 100644 --- a/tests/tasks/test_discovery.py +++ b/tests/tasks/test_discovery.py @@ -569,7 +569,7 @@ def test_discovery_falls_back_to_get_after_head_request_error( assert methods == ["HEAD", "GET"] -def test_discovery_falls_back_to_get_after_head_dns_failure( +def test_discovery_does_not_suppress_unexpected_head_error( app: Flask, sender_module: ModuleType ) -> None: methods: list[str] = [] @@ -588,11 +588,13 @@ def test_discovery_falls_back_to_get_after_head_dns_failure( transport=httpx.MockTransport(handler), event_hooks={"request": [request_hook]}, ) as client, + pytest.raises( + sender_module.TemporarySenderError, match="HEAD DNS lookup failed" + ), ): - endpoint = sender_module.discover_webmention_endpoint(client, TARGET_URL) + sender_module.discover_webmention_endpoint(client, TARGET_URL) - assert endpoint == ENDPOINT_URL - assert methods == ["GET"] + assert methods == [] def test_discovery_get_error_after_head_error_is_not_suppressed( @@ -753,6 +755,22 @@ def test_read_target_body_rejects_declared_oversized_body( sender_module.read_target_body(response) +def test_read_target_body_does_not_mask_unexpected_value_error( + app: Flask, sender_module: ModuleType, monkeypatch: pytest.MonkeyPatch +) -> None: + monkeypatch.setattr( + sender_module, + "read_limited_body", + Mock(side_effect=ValueError("unrelated processing error")), + ) + + with ( + app.app_context(), + pytest.raises(ValueError, match="unrelated processing error"), + ): + sender_module.read_target_body(httpx.Response(200)) + + def test_read_target_body_ignores_invalid_content_length( app: Flask, sender_module: ModuleType ) -> None: -- cgit v1.3.1