From c724c87eb5e23581732a275f1dd808da72932286 Mon Sep 17 00:00:00 2001 From: Dennis Fink Date: Wed, 18 Nov 2026 21:42:59 +0100 Subject: refactor(core): standardize filter form rendering Render received and sent list controls through their WTForms instances and use a shared `filter_form` template variable for consistent filter handling. --- webmentions_ssg/templates/received.html | 49 ++++++++------------------------- webmentions_ssg/templates/sent.html | 24 ++++++++-------- webmentions_ssg/views/received.py | 4 ++- webmentions_ssg/views/sources.py | 6 ++-- 4 files changed, 30 insertions(+), 53 deletions(-) diff --git a/webmentions_ssg/templates/received.html b/webmentions_ssg/templates/received.html index 8931601..e7ec5a8 100644 --- a/webmentions_ssg/templates/received.html +++ b/webmentions_ssg/templates/received.html @@ -56,52 +56,27 @@ SPDX-License-Identifier: BSD-3-Clause method="get" class="row g-2 align-items-end mb-4" role="search"> - - + {{ filter_form.sort }} + {{ filter_form.order }}
- - + {{ filter_form.status.label(class_="form-label") }} + {{ filter_form.status(class_="form-select") }}
- - + {{ filter_form.q.label(class_="form-label") }} + {{ filter_form.q(class_="form-control", placeholder="Search URLs") }}
- - + {{ filter_form.date_from.label(class_="form-label") }} + {{ filter_form.date_from(class_="form-control") }}
- - + {{ filter_form.date_to.label(class_="form-label") }} + {{ filter_form.date_to(class_="form-control") }}
- - + {{ filter_form.per_page.label(class_="form-label") }} + {{ filter_form.per_page(class_="form-control", min=1, max=max_received_page_size, step=1) }}
diff --git a/webmentions_ssg/templates/sent.html b/webmentions_ssg/templates/sent.html index 6febdb9..b613f4b 100644 --- a/webmentions_ssg/templates/sent.html +++ b/webmentions_ssg/templates/sent.html @@ -40,27 +40,27 @@ SPDX-License-Identifier: BSD-3-Clause method="get" class="row g-2 align-items-end mb-4" role="search"> - {{ form.sort }} - {{ form.order }} + {{ filter_form.sort }} + {{ filter_form.order }}
- {{ form.status.label(class_="form-label") }} - {{ form.status(class_="form-select") }} + {{ filter_form.status.label(class_="form-label") }} + {{ filter_form.status(class_="form-select") }}
- {{ form.q.label(class_="form-label") }} - {{ form.q(class_="form-control", placeholder="Search paths and URLs") }} + {{ filter_form.q.label(class_="form-label") }} + {{ filter_form.q(class_="form-control", placeholder="Search paths and URLs") }}
- {{ form.date_from.label(class_="form-label") }} - {{ form.date_from(class_="form-control") }} + {{ filter_form.date_from.label(class_="form-label") }} + {{ filter_form.date_from(class_="form-control") }}
- {{ form.date_to.label(class_="form-label") }} - {{ form.date_to(class_="form-control") }} + {{ filter_form.date_to.label(class_="form-label") }} + {{ filter_form.date_to(class_="form-control") }}
- {{ form.per_page.label(class_="form-label") }} - {{ form.per_page(class_="form-control", min=1, max=max_source_page_size, step=1) }} + {{ filter_form.per_page.label(class_="form-label") }} + {{ filter_form.per_page(class_="form-control", min=1, max=max_source_page_size, step=1) }}
diff --git a/webmentions_ssg/views/received.py b/webmentions_ssg/views/received.py index e49ee31..c273618 100644 --- a/webmentions_ssg/views/received.py +++ b/webmentions_ssg/views/received.py @@ -91,7 +91,8 @@ def received_list() -> ResponseReturnValue: :returns: Rendered page containing the paginated received Webmentions. """ - filters = received_filter_args(received_filter_form()) + filter_form = received_filter_form() + filters = received_filter_args(filter_form) query = sa.select(ReceivedWebmention) @@ -175,6 +176,7 @@ def received_list() -> ResponseReturnValue: page_size=page_size, sort_urls=sort_urls, max_received_page_size=current_app.config["RECEIVED_MAX_PAGE_SIZE"], + filter_form=filter_form, action_form=ConfirmActionForm(), ) diff --git a/webmentions_ssg/views/sources.py b/webmentions_ssg/views/sources.py index 84b98fb..a3dbb45 100644 --- a/webmentions_ssg/views/sources.py +++ b/webmentions_ssg/views/sources.py @@ -66,8 +66,8 @@ def source_filter_args(form: SourceFilterForm) -> SourceFilterArgs: @login_required def source_list() -> ResponseReturnValue: """Display source documents with filters for outgoing delivery problems.""" - form = source_filter_form() - filters = source_filter_args(form) + filter_form = source_filter_form() + filters = source_filter_args(filter_form) query = sa.select(SourceDocument).options( selectinload(SourceDocument.sent_webmentions) ) @@ -157,7 +157,6 @@ def source_list() -> ResponseReturnValue: "sent.html", title="Sent Webmentions", sources=sources, - form=form, filters=filters, sort_key=sort_key, sort_order=sort_order, @@ -165,6 +164,7 @@ def source_list() -> ResponseReturnValue: status_choices=SOURCE_STATUS_CHOICES, page_size=page_size, max_source_page_size=current_app.config["SOURCES_MAX_PAGE_SIZE"], + filter_form=filter_form, action_form=ConfirmActionForm(), ) -- cgit v1.3.1