aboutsummaryrefslogtreecommitdiff
path: root/webmentions_ssg (follow)
Commit message (Collapse)AuthorAge
* refactor(core): clarify Webmention mutation APIsDennis Fink9 days
| | | | | | | | Make in-place reset and reopen helpers return `None` so callers no longer perform pointless self-reassignment. Split explicit resend behavior into its own method instead of hiding it behind a boolean flag on `reopen`.
* refactor(core): centralize pending revision logicDennis Fink9 days
| | | | | | | | Make `SentWebmention.pending` a hybrid property so the same definition works in Python and SQL expressions. Reuse it across sender and scanner guards to remove duplicated revision checks.
* refactor(core): remove redundant abort returnsDennis Fink9 days
| | | | | | Call Flask `abort` directly in view guards since it always raises and never returns, simplifying error branches without changing response behavior.
* refactor(core): replace HTTP status magic numbersDennis Fink9 days
| | | | | | Use `HTTPStatus` constants for standard response codes and a named upper bound for retryable server errors so network and task status handling is self-documenting.
* fix(core): clarify Huey file path semanticsDennis Fink9 days
| | | | | | | | Document and test SQLAlchemy-style slash handling for file and SQLite Huey URLs, including distinct relative and absolute path forms. Update validation errors to show the supported three- and four-slash conventions.
* refactor(sender): flatten canonical URL parsingDennis Fink9 days
| | | | | | Return early when no canonical link is present so canonical URL validation can follow a linear path with less nesting and unchanged scan behavior.
* fix(core): make network task failures explicitDennis Fink9 days
| | | | | | | | | | Introduce a dedicated response-size error so callers only translate expected limit violations instead of masking unrelated `ValueError` exceptions. Ensure failed sockets are always closed, remove dead discovery error handling, and log unexpected sender failures with tracebacks before recording them.
* refactor(core): simplify session fingerprint validationDennis Fink9 days
| | | | | | Validate only the numeric user ID before lookup, then compare the complete stored session identifier against the current user ID with a constant-time byte check.
* refactor(core): simplify login password verificationDennis Fink9 days
| | | | | | | | | Replace the module-level dummy user with a lazily cached password hash so unknown usernames still perform a password check without hashing during every import. Use one linear verification path for existing, missing, and empty passwords.
* fix(core): harden session and redirect validationDennis Fink9 days
| | | | | | | | Reject non-string session identifiers explicitly and simplify fingerprint parsing so malformed authentication state fails closed. Tighten local redirect checks against control-character and backslash host tricks without relying on an unnecessary scheme check.
* chore(core): enforce Ruff docstring spacingDennis Fink9 days
| | | | | | Enable additional Ruff docstring checks for summary separation and closing quotes, then normalize migration and application docstrings to satisfy the new rules.
* refactor(core): avoid uuid module shadowing in modelsDennis Fink9 days
| | | | | | Import `UUID` and `uuid7` directly so model column attributes named `uuid` no longer shadow the module used for type annotations and default generators.
* fix(receiver): reopen raced submissions after cooldownDennis Fink9 days
| | | | | | | | | Recover a concurrently inserted Webmention through the same cooldown path as an existing submission so stale failures can be queued for verification. Extract digest lookup, insertion, and reopening helpers while preserving explicit SHA-256 collision handling.
* refactor(core): extract hostname resolution helperDennis Fink9 days
| | | | | | Move DNS resolution and address parsing into a dedicated helper so public address validation resolves hostnames through a single, testable path.
* fix(core): reject all Unicode control charactersDennis Fink9 days
| | | | | Use shared Unicode category validation so passwords reject C1 controls in addition to C0 and DEL, and reuse the same helper for URL validation.
* refactor(core): use EAFP for user creationDennis Fink9 days
| | | | | Rely on the database uniqueness constraint and existing `IntegrityError` handling instead of performing a redundant pre-insert user lookup.
* refactor(core): consolidate endpoint URL validationDennis Fink9 days
| | | | | | | | | Replace overlapping WTForms URL and regex checks with a single `HTTPURL` validator that enforces parseable HTTP(S) URLs without rewriting whitespace. Add coverage for malformed hosts and ports plus case-insensitive schemes.
* refactor(core): inline endpoint source comparisonDennis Fink9 days
| | | | | | Remove the generic cross-field equality validator and keep the source-versus-target check directly on `EndpointForm`, where the validation rule is actually used.
* fix(core): decouple task imports from app initializationDennis Fink10 days
| | | | | | | | | | Keep stable lazy task handles that register against the active Huey backend so modules can be imported before app creation and survive backend reinitialization. Separate package metadata and the shared blueprint from application startup to remove import-order dependencies and keep build-time version lookup lightweight.
* refactor(sender): simplify HTML endpoint discoveryDennis Fink10 days
| | | | | | Use a case-insensitive CSS selector to find Webmention links directly, removing manual relation parsing while preserving endpoint validation and document order.
* refactor(receiver): simplify HTML mention selectorsDennis Fink10 days
| | | | | | Store complete CSS selectors alongside their target attributes so HTML mention detection can query supported references directly without rebuilding selectors.
* refactor(core): use lowercase extension namesDennis Fink10 days
| | | | | | Rename shared Flask extension singletons to conventional lowercase names and update imports throughout the application and tests to remove redundant aliases.
* fix(core): validate Redis Huey URL schemesDennis Fink10 days
| | | | | | Parse Redis backend flavours explicitly so supported combinations preserve the correct redis or rediss scheme while malformed or unknown variants fail fast.
* chore(core): enable stricter Ruff lint rulesDennis Fink10 days
| | | | | | | | Expand Ruff checks for bugbear, complexity, pathlib, return statements, simplifications, upgrades, and docstring style. Apply the resulting behavior-neutral cleanup across application and test code.
* chore(core): fix task typing issuesDennis Fink10 days
| | | | | | Add explicit result assertions, broader parser annotations, and SQLAlchemy result casts so static type checking reflects the runtime guarantees of task code.
* refactor(core): simplify task control flowDennis Fink10 days
| | | | | | Replace unnecessary pattern matching and temporary assignments with direct conditionals and inline configuration access without changing task behavior.
* refactor(core): split modules by responsibilityDennis Fink10 days
| | | | | | | | Break up monolithic views, task helpers, networking, CLI, and application extension setup so each module owns a focused concern. Reorganize the test suite around the new boundaries while preserving existing Webmention behavior and coverage.
* fix(core): harden local setup and Huey configurationDennis Fink2026-10-31
| | | | | | | | | Create local development and test directories automatically so fresh checkouts can start without pre-existing logging or instance paths. Reject in-memory and blackhole Huey backends in production because they cannot reliably deliver queued work across separate web and worker processes.
* fix(core): harden login rate limiting behind proxiesDennis Fink2026-10-31
| | | | | | | | | | Trust forwarded client addresses only for an explicitly configured number of reverse-proxy hops so per-IP limits cannot be bypassed or collapsed in proxied deployments. Add a separate hashed per-username login limit across IPs to reduce distributed credential-guessing attempts without storing raw usernames in limiter keys.
* fix(sender): treat malformed requests as terminal failuresDennis Fink2026-10-31
| | | | | | | | | Reject invalid stored targets and local URL or protocol errors as permanent failures so unrecoverable requests do not consume the sender retry budget. Preserve the recorded attempt state while preventing duplicate retries for the same source revision.
* fix(sender): prevent source scanner path escapesDennis Fink2026-10-31
| | | | | | | | | Reject symlinked source files whose resolved targets leave the configured source directory so scans cannot read unintended files from the host filesystem. Normalize and validate ignored hostname patterns at startup and again at scan time to keep scanner filtering predictable.
* chore(core): add djlint template toolingDennis Fink2026-10-31
| | | | | | | | Add djlint to the development toolchain with Jinja, CSS, and JavaScript formatting rules so template style can be checked and normalized consistently. Reformat existing templates to match the configured conventions.
* fix(core): correct base template markupDennis Fink2026-10-31
| | | | | | | | Fix the Bootstrap spacing class and remove the stray closing container so the navigation markup is properly nested. Mark the decorative logo image with an empty alt attribute for accessibility.
* fix(receiver): prevent endless verification recoveryDennis Fink2026-10-31
| | | | | | | | Cap stale verification requeues so repeatedly lost or crashing tasks eventually become terminal failures instead of cycling indefinitely. Reject URLs that httpx cannot safely fetch before enqueueing, and persist unexpected verification errors as terminal failures.
* fix(core): reject IPv6 transition addressesDennis Fink2026-10-31
| | | | | | | | | | Harden public-address validation against NAT64, IPv4-compatible, 6to4, and IPv4-mapped IPv6 forms that can encapsulate private or metadata destinations. Apply the same check to literal form validation and DNS-resolved addresses so SSRF protections do not rely on Python's `is_global` behavior alone.
* feat(receiver): add resource limits and retentionDennis Fink2026-10-31
| | | | | | | | Bound incoming request and URL sizes so untrusted Webmention submissions cannot consume unbounded application or database resources. Purge old failed and deleted received Webmentions on a schedule, and use portable SHA-256 URL fingerprints to preserve uniqueness for long URLs.
* fix(core): harden session and credential securityDennis Fink2026-10-31
| | | | | | | | | | Require persistent non-placeholder signing keys outside local development and bind login sessions to the current password hash so password changes revoke existing cookies. Enforce a minimal password policy for user administration while preserving long Unicode passphrases without arbitrary composition limits.
* fix(core): replace Huey pickle serialization with JSONDennis Fink2026-10-30
| | | | | | | | | Prevent broker-controlled task and result payloads from deserializing arbitrary Python objects by using a restricted JSON serializer with an explicit type allowlist. Fail closed on serializer overrides and document broker isolation and migration requirements for existing pickle-backed deployments.
* fix(core): prevent DNS rebinding in HTTP requestsDennis Fink2026-10-30
| | | | | | | | | | Pin outbound connections to validated public IP addresses so DNS changes cannot redirect receiver or sender requests onto private or link-local networks. Apply the same protection across redirects, add an overall request deadline, and keep DNS resolution out of synchronous endpoint form validation.
* fix(sender): validate missing source directoriesDennis Fink2026-10-30
| | | | | | Resolve configured source paths without requiring them to exist first so missing directories produce the scanner's explicit directory validation error instead of leaking a lower-level path resolution exception.
* fix(receiver): recover stale Webmention verificationsDennis Fink2026-10-30
| | | | | | | | | Add a periodic recovery sweep for Webmentions left in received or verifying states after worker crashes, lost queue entries, or interrupted processing. Use atomic lease-style updates so stale workers cannot overwrite newer results, and index verification state for efficient recovery scans.
* fix(sender): make endpoint discovery more resilientDennis Fink2026-10-30
| | | | | | | | Fall back to GET when HEAD fails so targets that reject or mishandle HEAD can still advertise a Webmention endpoint. Ignore malformed or unsupported endpoint candidates and continue searching for the first valid HTTP endpoint.
* fix(receiver): handle punctuation around plain-text URLsDennis Fink2026-10-30
| | | | | | | | | Ignore surrounding prose punctuation when matching target IRIs in text/plain sources so valid Webmentions are not rejected when URLs appear in normal sentences. Preserve balanced URL parentheses and reject longer URLs that only share the target as a prefix.
* fix(sender): stabilize source content fingerprintsDennis Fink2026-10-30
| | | | | | | | | Hash normalized reader-facing content and outgoing targets instead of raw h-entry markup so generated attributes and relative timestamps do not trigger spurious source revisions or repeat Webmentions. Preserve meaningful changes such as image updates and reaction target changes while ignoring target ordering and other markup noise.
* fix(sender): retry manual scans on lock contentionDennis Fink2026-10-30
| | | | | | | | Ensure requested rescans are not silently dropped when a periodic scan already holds the scanner lock. Defer the manual task and retry it after the active scan finishes while still propagating unrelated scan failures.
* fix(sender): prevent concurrent duplicate sendsDennis Fink2026-10-30
| | | | | | | | | Serialize delivery attempts per Webmention so duplicate queued tasks cannot send the same revision concurrently or consume additional retry attempts. Scope locks by Webmention UUID so unrelated deliveries can still run in parallel.
* feat(sender): add persistent retry backoffDennis Fink2026-10-30
| | | | | | | | | | Persist retry state per source revision so temporary delivery failures survive worker restarts and duplicate queued tasks cannot bypass the retry schedule. Use capped exponential backoff, stop after a configurable attempt limit, and reset the retry budget when a source changes or an admin resends manually.
* fix(sender): ignore inconclusive empty scansDennis Fink2026-10-30
| | | | | | | | Treat scans with no successfully processed source pages as inconclusive so a temporary empty or partially rebuilt output directory cannot mark every source deleted or trigger removal Webmentions. Defer pending sends until at least one source is scanned successfully.
* fix(sender): prevent duplicate canonical source URLsDennis Fink2026-10-30
| | | | | | | | | Keep persisted sources, including deleted ones, as owners of their canonical URLs so newly scanned aliases cannot claim the same source identity. Skip duplicate canonical paths without blocking unrelated sources from being saved or queued for delivery.
* fix(sender): isolate source parser failuresDennis Fink2026-10-30
| | | | | | | | | Prevent malformed pages or unexpected third-party parser exceptions from aborting an entire source scan or causing previously known sources to be treated as deleted. Keep persistence failures visible so database errors still fail the scan.