aboutsummaryrefslogtreecommitdiff
path: root/webmentions_ssg/views
diff options
context:
space:
mode:
Diffstat (limited to 'webmentions_ssg/views')
-rw-r--r--webmentions_ssg/views/admin.py11
-rw-r--r--webmentions_ssg/views/endpoint.py7
2 files changed, 10 insertions, 8 deletions
diff --git a/webmentions_ssg/views/admin.py b/webmentions_ssg/views/admin.py
index 1025e69..2ccd92a 100644
--- a/webmentions_ssg/views/admin.py
+++ b/webmentions_ssg/views/admin.py
@@ -5,6 +5,7 @@
"""Authenticated incoming and outgoing Webmention management."""
import uuid
+from http import HTTPStatus
import sqlalchemy as sa
from flask import abort, flash, redirect, render_template, request, url_for
@@ -50,7 +51,7 @@ def delete_received_webmention(identifier: uuid.UUID) -> ResponseReturnValue:
:returns: Redirect response to the received Webmentions view.
"""
if not forms.AdminActionForm().validate_on_submit():
- abort(400)
+ abort(HTTPStatus.BAD_REQUEST)
webmention = db.get_or_404(ReceivedWebmention, identifier)
@@ -75,7 +76,7 @@ def reverify_received_webmention(identifier: uuid.UUID) -> ResponseReturnValue:
:returns: Redirect response to the received Webmentions view.
"""
if not forms.AdminActionForm().validate_on_submit():
- abort(400)
+ abort(HTTPStatus.BAD_REQUEST)
webmention = db.get_or_404(ReceivedWebmention, identifier)
@@ -121,7 +122,7 @@ def rescan_sent_sources() -> ResponseReturnValue:
:returns: Redirect response to the sent Webmentions view.
"""
if not forms.AdminActionForm().validate_on_submit():
- abort(400)
+ abort(HTTPStatus.BAD_REQUEST)
manual_scan_sources()
flash("Source rescan queued.", "success")
@@ -172,12 +173,12 @@ def resend_sent_webmention(
:returns: Redirect response to the source details view.
"""
if not forms.AdminActionForm().validate_on_submit():
- abort(400)
+ abort(HTTPStatus.BAD_REQUEST)
webmention = db.get_or_404(SentWebmention, webmention_identifier)
if webmention.source_id != source_identifier:
- abort(404)
+ abort(HTTPStatus.NOT_FOUND)
# Requeue the existing desired revision instead of inventing a new source
# revision. send_webmention() otherwise exits when this revision has already
diff --git a/webmentions_ssg/views/endpoint.py b/webmentions_ssg/views/endpoint.py
index 85ec398..06740e5 100644
--- a/webmentions_ssg/views/endpoint.py
+++ b/webmentions_ssg/views/endpoint.py
@@ -6,6 +6,7 @@
import uuid
from datetime import UTC, datetime, timedelta
+from http import HTTPStatus
from typing import cast
import sqlalchemy as sa
@@ -141,7 +142,7 @@ def endpoint() -> ResponseReturnValue:
form = forms.EndpointForm(meta={"csrf": False})
if not form.validate_on_submit():
- return form.errors, 400
+ return form.errors, HTTPStatus.BAD_REQUEST
source = cast(str, form.source.data)
target = cast(str, form.target.data)
@@ -149,7 +150,7 @@ def endpoint() -> ResponseReturnValue:
result = submit_received(source, target)
if result is None:
- return {"error": "Webmention URL fingerprint conflict"}, 409
+ return {"error": "Webmention URL fingerprint conflict"}, HTTPStatus.CONFLICT
identifier, should_verify = result
@@ -158,7 +159,7 @@ def endpoint() -> ResponseReturnValue:
status_url = url_for("root.status", identifier=str(identifier), _external=True)
- return Response(status=201, headers={"Location": status_url})
+ return Response(status=HTTPStatus.CREATED, headers={"Location": status_url})
@root_page.route("/status/<uuid:identifier>")