aboutsummaryrefslogtreecommitdiff
path: root/tests/views/test_source_domains.py
diff options
context:
space:
mode:
Diffstat (limited to '')
-rw-r--r--tests/views/test_moderation.py (renamed from tests/views/test_source_domains.py)75
1 files changed, 34 insertions, 41 deletions
diff --git a/tests/views/test_source_domains.py b/tests/views/test_moderation.py
index c9e72b2..7f683d4 100644
--- a/tests/views/test_source_domains.py
+++ b/tests/views/test_moderation.py
@@ -15,12 +15,9 @@ from flask import Flask
from flask.testing import FlaskClient
from webmentions_ssg import db
-from webmentions_ssg.models import (
- AllowedSource,
- BlockedSource,
- ReceivedWebmention,
- ReceivedWebmentionStatus,
-)
+from webmentions_ssg.models.moderation import AllowedDomain, BlockedDomain
+from webmentions_ssg.models.received import ReceivedWebmention, ReceivedWebmentionStatus
+from webmentions_ssg.moderation_policy import rejection_reason
from webmentions_ssg.tasks.verification import VerificationClaim
from .helpers import SOURCE_URL, TARGET_URL, create_received_webmention, log_in
@@ -28,9 +25,9 @@ from .helpers import SOURCE_URL, TARGET_URL, create_received_webmention, log_in
def test_source_rules_require_login(client: FlaskClient) -> None:
for method, path, data in (
- ("get", "/source-domains", None),
- ("post", "/source-domains/blocked/add", {"domain": "bad.example"}),
- ("post", "/source-domains/blocked/1/delete", None),
+ ("get", "/moderation", None),
+ ("post", "/moderation/blocked/add", {"domain": "bad.example"}),
+ ("post", "/moderation/blocked/1/delete", None),
):
response = client.open(path, method=method.upper(), data=data)
assert response.status_code == HTTPStatus.FOUND
@@ -39,31 +36,29 @@ def test_source_rules_require_login(client: FlaskClient) -> None:
def test_add_and_unblock_source_domain(app: Flask, client: FlaskClient) -> None:
log_in(app, client)
- response = client.post(
- "/source-domains/blocked/add", data={"domain": "SPAM.Example."}
- )
+ response = client.post("/moderation/blocked/add", data={"domain": "SPAM.Example."})
assert response.status_code == HTTPStatus.FOUND
- response = client.post(
- "/source-domains/blocked/add", data={"domain": "spam.example"}
- )
+ assert response.headers["Location"].endswith("/moderation")
+ response = client.post("/moderation/blocked/add", data={"domain": "spam.example"})
assert response.status_code == HTTPStatus.FOUND
with app.app_context():
- rows = db.session.scalars(sa.select(BlockedSource)).all()
+ rows = db.session.scalars(sa.select(BlockedDomain)).all()
assert len(rows) == 1
assert rows[0].domain == "spam.example"
entry_id = rows[0].id
- response = client.get("/source-domains")
+ response = client.get("/moderation")
assert response.status_code == HTTPStatus.OK
assert b"spam.example" in response.data
assert b"Unblock" in response.data
assert b"Source rules" in response.data
- response = client.post(f"/source-domains/blocked/{entry_id}/delete")
+ response = client.post(f"/moderation/blocked/{entry_id}/delete")
assert response.status_code == HTTPStatus.FOUND
+ assert response.headers["Location"].endswith("/moderation")
with app.app_context():
- assert db.session.scalar(sa.select(sa.func.count(BlockedSource.id))) == 0
+ assert db.session.scalar(sa.select(sa.func.count(BlockedDomain.id))) == 0
def test_allowlist_can_be_managed_while_mode_is_off(
@@ -71,14 +66,14 @@ def test_allowlist_can_be_managed_while_mode_is_off(
) -> None:
log_in(app, client)
response = client.post(
- "/source-domains/allowed/add", data={"domain": "friends.example"}
+ "/moderation/allowed/add", data={"domain": "friends.example"}
)
assert response.status_code == HTTPStatus.FOUND
with app.app_context():
- row = db.session.scalar(sa.select(AllowedSource))
+ row = db.session.scalar(sa.select(AllowedDomain))
assert row is not None
assert row.domain == "friends.example"
- assert b"disabled" in client.get("/source-domains").data
+ assert b"disabled" in client.get("/moderation").data
@pytest.mark.parametrize(
@@ -88,17 +83,17 @@ def test_invalid_domains_are_rejected(
client: FlaskClient, app: Flask, domain: str
) -> None:
log_in(app, client)
- response = client.post("/source-domains/blocked/add", data={"domain": domain})
+ response = client.post("/moderation/blocked/add", data={"domain": domain})
assert response.status_code == HTTPStatus.BAD_REQUEST
def test_invalid_list_kind_and_missing_entry(app: Flask, client: FlaskClient) -> None:
log_in(app, client)
assert (
- client.post("/source-domains/nope/add", data={"domain": "test.org"}).status_code
+ client.post("/moderation/nope/add", data={"domain": "test.org"}).status_code
== 404
)
- assert client.post("/source-domains/blocked/123/delete").status_code == 404
+ assert client.post("/moderation/blocked/123/delete").status_code == 404
def test_received_row_can_block_domain(app: Flask, client: FlaskClient) -> None:
@@ -109,7 +104,7 @@ def test_received_row_can_block_domain(app: Flask, client: FlaskClient) -> None:
response = client.post(f"/received/{mention_id}/block-source")
assert response.status_code == HTTPStatus.FOUND
with app.app_context():
- rule = db.session.scalar(sa.select(BlockedSource))
+ rule = db.session.scalar(sa.select(BlockedDomain))
assert rule is not None and rule.domain == "spam.example"
@@ -126,7 +121,7 @@ def test_block_selected_source_domains_deduplicates_and_preserves_mentions(
second = create_received_webmention(app, source="https://second.example/article")
unselected = create_received_webmention(app, source="https://other.example/article")
with app.app_context():
- db.session.add(BlockedSource(domain="second.example"))
+ db.session.add(BlockedDomain(domain="second.example"))
db.session.commit()
response = client.post(
@@ -142,19 +137,17 @@ def test_block_selected_source_domains_deduplicates_and_preserves_mentions(
"sort": ["source"],
}
with app.app_context():
- assert set(db.session.scalars(sa.select(BlockedSource.domain))) == {
+ assert set(db.session.scalars(sa.select(BlockedDomain.domain))) == {
"spam.example",
"second.example",
}
for identifier in (first, same_domain, second, unselected):
assert db.session.get(ReceivedWebmention, identifier) is not None
- from webmentions_ssg.source_policy import source_rejection_reason
-
assert (
- source_rejection_reason("https://child.spam.example/post")
+ rejection_reason("https://child.spam.example/post")
== "Source domain is blocked"
)
- assert source_rejection_reason("https://other.example/post") is None
+ assert rejection_reason("https://other.example/post") is None
# Repeating the action is idempotent.
response = client.post(
@@ -163,7 +156,7 @@ def test_block_selected_source_domains_deduplicates_and_preserves_mentions(
)
assert response.status_code == HTTPStatus.FOUND
with app.app_context():
- assert db.session.scalar(sa.select(sa.func.count(BlockedSource.id))) == 2
+ assert db.session.scalar(sa.select(sa.func.count(BlockedDomain.id))) == 2
def test_bulk_block_rejects_invalid_source_without_partial_changes(
@@ -179,7 +172,7 @@ def test_bulk_block_rejects_invalid_source_without_partial_changes(
)
assert response.status_code == HTTPStatus.BAD_REQUEST
with app.app_context():
- assert db.session.scalar(sa.select(sa.func.count(BlockedSource.id))) == 0
+ assert db.session.scalar(sa.select(sa.func.count(BlockedDomain.id))) == 0
def test_bulk_block_action_enforces_csrf(app: Flask, client: FlaskClient) -> None:
@@ -192,7 +185,7 @@ def test_bulk_block_action_enforces_csrf(app: Flask, client: FlaskClient) -> Non
)
assert response.status_code == HTTPStatus.BAD_REQUEST
with app.app_context():
- assert db.session.scalar(sa.select(sa.func.count(BlockedSource.id))) == 0
+ assert db.session.scalar(sa.select(sa.func.count(BlockedDomain.id))) == 0
def test_endpoint_rejects_blocked_without_queue_or_insert(
@@ -203,7 +196,7 @@ def test_endpoint_rejects_blocked_without_queue_or_insert(
enqueue = Mock()
monkeypatch.setattr(endpoint, "verify_webmention", enqueue)
with app.app_context():
- db.session.add(BlockedSource(domain="source.example"))
+ db.session.add(BlockedDomain(domain="source.example"))
db.session.commit()
response = client.post(
@@ -221,14 +214,14 @@ def test_allowlist_mode_rejects_unlisted_and_allows_listed(
) -> None:
from webmentions_ssg.views import endpoint
- app.config["SOURCE_ALLOWLIST_ENABLED"] = True
+ app.config["ALLOWLIST_ENABLED"] = True
enqueue = Mock()
monkeypatch.setattr(endpoint, "verify_webmention", enqueue)
data = {"source": SOURCE_URL, "target": TARGET_URL}
assert client.post("/endpoint", data=data).status_code == HTTPStatus.FORBIDDEN
with app.app_context():
- db.session.add(AllowedSource(domain="source.example"))
+ db.session.add(AllowedDomain(domain="source.example"))
db.session.commit()
assert client.post("/endpoint", data=data).status_code == HTTPStatus.CREATED
@@ -249,7 +242,7 @@ def test_worker_checks_rules_before_fetch(
fetch = Mock()
monkeypatch.setattr(verification, "source_mentions_target", fetch)
with app.app_context():
- db.session.add(BlockedSource(domain="source.example"))
+ db.session.add(BlockedDomain(domain="source.example"))
db.session.commit()
assert verification.determine_verification_outcome(claim) == (
ReceivedWebmentionStatus.FAILED,
@@ -272,7 +265,7 @@ def test_queued_worker_skips_fetch_after_source_is_blocked(
identifier = mention.uuid
# A user blocks the domain after the submission has already been queued.
- db.session.add(BlockedSource(domain="source.example"))
+ db.session.add(BlockedDomain(domain="source.example"))
db.session.commit()
fetch = Mock()
@@ -291,7 +284,7 @@ def test_admin_actions_enforce_csrf(app: Flask, client: FlaskClient) -> None:
app.config["WTF_CSRF_ENABLED"] = True
assert (
client.post(
- "/source-domains/blocked/add", data={"domain": "spam.example"}
+ "/moderation/blocked/add", data={"domain": "spam.example"}
).status_code
== HTTPStatus.BAD_REQUEST
)