aboutsummaryrefslogtreecommitdiff
path: root/tests/forms
diff options
context:
space:
mode:
Diffstat (limited to '')
-rw-r--r--tests/forms/__init__.py3
-rw-r--r--tests/forms/test_admin.py13
-rw-r--r--tests/forms/test_endpoint.py (renamed from tests/test_forms.py)201
-rw-r--r--tests/forms/test_received.py93
-rw-r--r--tests/forms/test_user.py35
-rw-r--r--tests/forms/test_validators.py88
6 files changed, 233 insertions, 200 deletions
diff --git a/tests/forms/__init__.py b/tests/forms/__init__.py
new file mode 100644
index 0000000..25d78d5
--- /dev/null
+++ b/tests/forms/__init__.py
@@ -0,0 +1,3 @@
+# SPDX-FileCopyrightText: 2026 Dennis Fink <me+coding@dennisfink.me>
+#
+# SPDX-License-Identifier: BSD-3-Clause
diff --git a/tests/forms/test_admin.py b/tests/forms/test_admin.py
new file mode 100644
index 0000000..cb011ee
--- /dev/null
+++ b/tests/forms/test_admin.py
@@ -0,0 +1,13 @@
+# SPDX-FileCopyrightText: 2026 Dennis Fink <me+coding@dennisfink.me>
+#
+# SPDX-License-Identifier: BSD-3-Clause
+
+from flask import Flask
+
+from webmentions_ssg.forms.admin import ConfirmActionForm
+
+
+def test_admin_action_form_accepts_submission(app: Flask) -> None:
+ with app.test_request_context(method="POST"):
+ form = ConfirmActionForm(meta={"csrf": False})
+ assert form.validate()
diff --git a/tests/test_forms.py b/tests/forms/test_endpoint.py
index c6a8b25..11f233d 100644
--- a/tests/test_forms.py
+++ b/tests/forms/test_endpoint.py
@@ -5,26 +5,13 @@
import pytest
from flask import Flask
from werkzeug.datastructures import MultiDict
-from wtforms import Form, StringField, ValidationError
-from webmentions_ssg.forms import (
- AllowedTargetHostname,
- ConfirmActionForm,
- LoginForm,
- MaxURLBytes,
- ReceivedWebmentionFilterForm,
- RejectNonPublicIPLiteral,
- WebmentionSubmissionForm,
-)
+from webmentions_ssg.forms.endpoint import WebmentionSubmissionForm
VALID_SOURCE = "https://source.example/post"
VALID_TARGET = "https://dennisfink.me/blog/example/"
-class URLForm(Form):
- url = StringField("URL")
-
-
@pytest.mark.parametrize(
("form_data", "invalid_field", "expected_error"),
[
@@ -118,122 +105,6 @@ def test_endpoint_form_accepts_valid_data(app: Flask) -> None:
assert form.errors == {}
-@pytest.mark.parametrize(
- ("form_data", "invalid_field"),
- [
- pytest.param({"password": "secret"}, "username", id="username-required"),
- pytest.param({"username": "admin"}, "password", id="password-required"),
- ],
-)
-def test_login_form_requires_credentials(
- app: Flask, form_data: dict[str, str], invalid_field: str
-) -> None:
- with app.test_request_context("/login", method="POST"):
- form = LoginForm(formdata=MultiDict(form_data), meta={"csrf": False})
-
- assert not form.validate()
- assert "This field is required." in form.errors[invalid_field]
-
-
-def test_login_form_accepts_credentials(app: Flask) -> None:
- with app.test_request_context("/login", method="POST"):
- form = LoginForm(
- formdata=MultiDict({"username": "admin", "password": "secret"}),
- meta={"csrf": False},
- )
- assert form.validate()
-
-
-def test_received_filter_form_accepts_valid_get_params(app: Flask) -> None:
- with app.test_request_context("/received", method="GET"):
- form = ReceivedWebmentionFilterForm(
- formdata=MultiDict(
- {
- "status": "declined",
- "q": "example.org",
- "date_from": "2026-11-08",
- "date_to": "2026-11-14",
- }
- ),
- meta={"csrf": False},
- )
- assert form.validate()
- assert form.status.data == "declined"
- assert form.q.data == "example.org"
- assert form.date_from.data.isoformat() == "2026-11-08"
- assert form.date_to.data.isoformat() == "2026-11-14"
- assert "csrf_token" not in form._fields
-
-
-@pytest.mark.parametrize(
- "data",
- [
- {"status": "unknown"},
- {"date_from": "not-a-date"},
- {"date_from": "2026-11-8"},
- {"date_to": "2026-02-30"},
- {"date_from": "2026-11-15", "date_to": "2026-11-08"},
- ],
-)
-def test_received_filter_form_rejects_invalid_get_params(
- app: Flask, data: dict[str, str]
-) -> None:
- with app.test_request_context("/received", method="GET"):
- form = ReceivedWebmentionFilterForm(
- formdata=MultiDict(data), meta={"csrf": False}
- )
- assert not form.validate()
- assert form.errors
-
-
-def test_received_filter_form_validates_sort_and_page_size(app: Flask) -> None:
- with app.test_request_context("/received", method="GET"):
- form = ReceivedWebmentionFilterForm(
- formdata=MultiDict({"sort": "updated", "order": "asc", "per_page": "37"}),
- meta={"csrf": False},
- )
- assert form.validate()
- assert form.sort.data == "updated"
- assert form.order.data == "asc"
- assert form.per_page.data == 37
-
- with app.test_request_context("/received", method="GET"):
- form = ReceivedWebmentionFilterForm(formdata=MultiDict(), meta={"csrf": False})
- assert form.validate()
- assert (form.sort.data, form.order.data, form.per_page.data) == (
- "received",
- "desc",
- 25,
- )
-
-
-@pytest.mark.parametrize(
- "data",
- [
- {"sort": "invalid"},
- {"order": "invalid"},
- {"per_page": "0"},
- {"per_page": "101"},
- {"per_page": "invalid"},
- ],
-)
-def test_received_filter_form_rejects_invalid_sort_and_page_size(
- app: Flask, data: dict[str, str]
-) -> None:
- with app.test_request_context("/received", method="GET"):
- form = ReceivedWebmentionFilterForm(
- formdata=MultiDict(data), meta={"csrf": False}
- )
- assert not form.validate()
- assert form.errors
-
-
-def test_admin_action_form_accepts_submission(app: Flask) -> None:
- with app.test_request_context(method="POST"):
- form = ConfirmActionForm(meta={"csrf": False})
- assert form.validate()
-
-
def test_endpoint_does_not_do_dns_in_web_request(
app: Flask, monkeypatch: pytest.MonkeyPatch
) -> None:
@@ -355,73 +226,3 @@ def test_endpoint_form_rejects_matching_source_and_target(app: Flask) -> None:
assert not form.validate()
assert "Field must not be equal to target." in form.errors["source"]
-
-
-def test_allowed_hostname_accepts_configured_hostname(app: Flask) -> None:
- app.config["ALLOWED_TARGET_HOSTNAMES"] = ["dennisfink.me"]
- form = URLForm(MultiDict({"url": "https://dennisfink.me/blog/example/"}))
- with app.app_context():
- AllowedTargetHostname()(form, form.url)
-
-
-def test_allowed_hostname_rejects_unconfigured_hostname(app: Flask) -> None:
- app.config["ALLOWED_TARGET_HOSTNAMES"] = ["dennisfink.me"]
- form = URLForm(MultiDict({"url": "https://example.com/post"}))
- with app.app_context(), pytest.raises(ValidationError, match="Invalid input"):
- AllowedTargetHostname()(form, form.url)
-
-
-def test_allowed_hostname_uses_custom_message(app: Flask) -> None:
- app.config["ALLOWED_TARGET_HOSTNAMES"] = ["dennisfink.me"]
- form = URLForm(MultiDict({"url": "https://example.com/post"}))
- with (
- app.app_context(),
- pytest.raises(ValidationError, match="Hostname is not allowed"),
- ):
- AllowedTargetHostname("Hostname is not allowed")(form, form.url)
-
-
-@pytest.mark.parametrize(
- "address",
- ["64:ff9b::a9fe:a9fe", "::10.0.0.1", "2002:a9fe:a9fe::1", "::ffff:169.254.169.254"],
-)
-def test_public_ip_literal_rejects_ipv6_transition_addresses(address: str) -> None:
- form = URLForm(MultiDict({"url": f"https://[{address}]/"}))
- with pytest.raises(ValidationError, match="URL must use a public address"):
- RejectNonPublicIPLiteral()(form, form.url)
-
-
-def test_public_ip_literal_accepts_public_ipv6_address() -> None:
- form = URLForm(MultiDict({"url": "https://[2606:2800:220:1:248:1893:25c8:1946]/"}))
- RejectNonPublicIPLiteral()(form, form.url)
-
-
-def test_allowed_hostname_handles_invalid_ipv6(app: Flask) -> None:
- form = URLForm(MultiDict({"url": "http://[::1"}))
- with app.app_context(), pytest.raises(ValidationError, match="Invalid input"):
- AllowedTargetHostname()(form, form.url)
-
-
-def test_url_max_bytes_respects_utf8_byte_length_and_current_config(app: Flask) -> None:
- validator = MaxURLBytes()
- form = URLForm(MultiDict({"url": "é" * 3}))
- with app.app_context():
- app.config["MAX_WEBMENTION_URL_BYTES"] = 6
- validator(form, form.url)
- app.config["MAX_WEBMENTION_URL_BYTES"] = 5
- with pytest.raises(ValidationError, match="5 bytes"):
- validator(form, form.url)
-
-
-def test_url_max_bytes_custom_message(app: Flask) -> None:
- form = URLForm(MultiDict({"url": "too-long"}))
- with app.app_context():
- app.config["MAX_WEBMENTION_URL_BYTES"] = 2
- with pytest.raises(ValidationError, match="URL too long"):
- MaxURLBytes(message="URL too long")(form, form.url)
-
-
-def test_url_max_bytes_rejects_malformed_unicode(app: Flask) -> None:
- form = URLForm(MultiDict({"url": "\ud800"}))
- with app.app_context(), pytest.raises(ValidationError, match="valid UTF-8"):
- MaxURLBytes()(form, form.url)
diff --git a/tests/forms/test_received.py b/tests/forms/test_received.py
new file mode 100644
index 0000000..4ef9ed3
--- /dev/null
+++ b/tests/forms/test_received.py
@@ -0,0 +1,93 @@
+# SPDX-FileCopyrightText: 2026 Dennis Fink <me+coding@dennisfink.me>
+#
+# SPDX-License-Identifier: BSD-3-Clause
+
+import pytest
+from flask import Flask
+from werkzeug.datastructures import MultiDict
+
+from webmentions_ssg.forms.received import ReceivedWebmentionFilterForm
+
+
+def test_received_filter_form_accepts_valid_get_params(app: Flask) -> None:
+ with app.test_request_context("/received", method="GET"):
+ form = ReceivedWebmentionFilterForm(
+ formdata=MultiDict(
+ {
+ "status": "declined",
+ "q": "example.org",
+ "date_from": "2026-11-08",
+ "date_to": "2026-11-14",
+ }
+ ),
+ meta={"csrf": False},
+ )
+ assert form.validate()
+ assert form.status.data == "declined"
+ assert form.q.data == "example.org"
+ assert form.date_from.data.isoformat() == "2026-11-08"
+ assert form.date_to.data.isoformat() == "2026-11-14"
+ assert "csrf_token" not in form._fields
+
+
+@pytest.mark.parametrize(
+ "data",
+ [
+ {"status": "unknown"},
+ {"date_from": "not-a-date"},
+ {"date_from": "2026-11-8"},
+ {"date_to": "2026-02-30"},
+ {"date_from": "2026-11-15", "date_to": "2026-11-08"},
+ ],
+)
+def test_received_filter_form_rejects_invalid_get_params(
+ app: Flask, data: dict[str, str]
+) -> None:
+ with app.test_request_context("/received", method="GET"):
+ form = ReceivedWebmentionFilterForm(
+ formdata=MultiDict(data), meta={"csrf": False}
+ )
+ assert not form.validate()
+ assert form.errors
+
+
+def test_received_filter_form_validates_sort_and_page_size(app: Flask) -> None:
+ with app.test_request_context("/received", method="GET"):
+ form = ReceivedWebmentionFilterForm(
+ formdata=MultiDict({"sort": "updated", "order": "asc", "per_page": "37"}),
+ meta={"csrf": False},
+ )
+ assert form.validate()
+ assert form.sort.data == "updated"
+ assert form.order.data == "asc"
+ assert form.per_page.data == 37
+
+ with app.test_request_context("/received", method="GET"):
+ form = ReceivedWebmentionFilterForm(formdata=MultiDict(), meta={"csrf": False})
+ assert form.validate()
+ assert (form.sort.data, form.order.data, form.per_page.data) == (
+ "received",
+ "desc",
+ 25,
+ )
+
+
+@pytest.mark.parametrize(
+ "data",
+ [
+ {"sort": "invalid"},
+ {"order": "invalid"},
+ {"per_page": "0"},
+ {"per_page": "101"},
+ {"per_page": "invalid"},
+ ],
+)
+def test_received_filter_form_rejects_invalid_sort_and_page_size(
+ app: Flask, data: dict[str, str]
+) -> None:
+ with app.test_request_context("/received", method="GET"):
+ form = ReceivedWebmentionFilterForm(
+ formdata=MultiDict(data), meta={"csrf": False}
+ )
+ assert not form.validate()
+ assert form.errors
diff --git a/tests/forms/test_user.py b/tests/forms/test_user.py
new file mode 100644
index 0000000..4b35a9a
--- /dev/null
+++ b/tests/forms/test_user.py
@@ -0,0 +1,35 @@
+# SPDX-FileCopyrightText: 2026 Dennis Fink <me+coding@dennisfink.me>
+#
+# SPDX-License-Identifier: BSD-3-Clause
+
+import pytest
+from flask import Flask
+from werkzeug.datastructures import MultiDict
+
+from webmentions_ssg.forms.user import LoginForm
+
+
+@pytest.mark.parametrize(
+ ("form_data", "invalid_field"),
+ [
+ pytest.param({"password": "secret"}, "username", id="username-required"),
+ pytest.param({"username": "admin"}, "password", id="password-required"),
+ ],
+)
+def test_login_form_requires_credentials(
+ app: Flask, form_data: dict[str, str], invalid_field: str
+) -> None:
+ with app.test_request_context("/login", method="POST"):
+ form = LoginForm(formdata=MultiDict(form_data), meta={"csrf": False})
+
+ assert not form.validate()
+ assert "This field is required." in form.errors[invalid_field]
+
+
+def test_login_form_accepts_credentials(app: Flask) -> None:
+ with app.test_request_context("/login", method="POST"):
+ form = LoginForm(
+ formdata=MultiDict({"username": "admin", "password": "secret"}),
+ meta={"csrf": False},
+ )
+ assert form.validate()
diff --git a/tests/forms/test_validators.py b/tests/forms/test_validators.py
new file mode 100644
index 0000000..4234552
--- /dev/null
+++ b/tests/forms/test_validators.py
@@ -0,0 +1,88 @@
+# SPDX-FileCopyrightText: 2026 Dennis Fink <me+coding@dennisfink.me>
+#
+# SPDX-License-Identifier: BSD-3-Clause
+
+import pytest
+from flask import Flask
+from werkzeug.datastructures import MultiDict
+from wtforms import Form, StringField, ValidationError
+
+from webmentions_ssg.forms.validators import (
+ AllowedTargetHostname,
+ MaxURLBytes,
+ RejectNonPublicIPLiteral,
+)
+
+
+class URLForm(Form):
+ url = StringField("URL")
+
+
+def test_allowed_hostname_accepts_configured_hostname(app: Flask) -> None:
+ app.config["ALLOWED_TARGET_HOSTNAMES"] = ["dennisfink.me"]
+ form = URLForm(MultiDict({"url": "https://dennisfink.me/blog/example/"}))
+ with app.app_context():
+ AllowedTargetHostname()(form, form.url)
+
+
+def test_allowed_hostname_rejects_unconfigured_hostname(app: Flask) -> None:
+ app.config["ALLOWED_TARGET_HOSTNAMES"] = ["dennisfink.me"]
+ form = URLForm(MultiDict({"url": "https://example.com/post"}))
+ with app.app_context(), pytest.raises(ValidationError, match="Invalid input"):
+ AllowedTargetHostname()(form, form.url)
+
+
+def test_allowed_hostname_uses_custom_message(app: Flask) -> None:
+ app.config["ALLOWED_TARGET_HOSTNAMES"] = ["dennisfink.me"]
+ form = URLForm(MultiDict({"url": "https://example.com/post"}))
+ with (
+ app.app_context(),
+ pytest.raises(ValidationError, match="Hostname is not allowed"),
+ ):
+ AllowedTargetHostname("Hostname is not allowed")(form, form.url)
+
+
+@pytest.mark.parametrize(
+ "address",
+ ["64:ff9b::a9fe:a9fe", "::10.0.0.1", "2002:a9fe:a9fe::1", "::ffff:169.254.169.254"],
+)
+def test_public_ip_literal_rejects_ipv6_transition_addresses(address: str) -> None:
+ form = URLForm(MultiDict({"url": f"https://[{address}]/"}))
+ with pytest.raises(ValidationError, match="URL must use a public address"):
+ RejectNonPublicIPLiteral()(form, form.url)
+
+
+def test_public_ip_literal_accepts_public_ipv6_address() -> None:
+ form = URLForm(MultiDict({"url": "https://[2606:2800:220:1:248:1893:25c8:1946]/"}))
+ RejectNonPublicIPLiteral()(form, form.url)
+
+
+def test_allowed_hostname_handles_invalid_ipv6(app: Flask) -> None:
+ form = URLForm(MultiDict({"url": "http://[::1"}))
+ with app.app_context(), pytest.raises(ValidationError, match="Invalid input"):
+ AllowedTargetHostname()(form, form.url)
+
+
+def test_url_max_bytes_respects_utf8_byte_length_and_current_config(app: Flask) -> None:
+ validator = MaxURLBytes()
+ form = URLForm(MultiDict({"url": "é" * 3}))
+ with app.app_context():
+ app.config["MAX_WEBMENTION_URL_BYTES"] = 6
+ validator(form, form.url)
+ app.config["MAX_WEBMENTION_URL_BYTES"] = 5
+ with pytest.raises(ValidationError, match="5 bytes"):
+ validator(form, form.url)
+
+
+def test_url_max_bytes_custom_message(app: Flask) -> None:
+ form = URLForm(MultiDict({"url": "too-long"}))
+ with app.app_context():
+ app.config["MAX_WEBMENTION_URL_BYTES"] = 2
+ with pytest.raises(ValidationError, match="URL too long"):
+ MaxURLBytes(message="URL too long")(form, form.url)
+
+
+def test_url_max_bytes_rejects_malformed_unicode(app: Flask) -> None:
+ form = URLForm(MultiDict({"url": "\ud800"}))
+ with app.app_context(), pytest.raises(ValidationError, match="valid UTF-8"):
+ MaxURLBytes()(form, form.url)