diff options
Diffstat (limited to '')
| -rw-r--r-- | tests/cli/test_users.py | 110 |
1 files changed, 96 insertions, 14 deletions
diff --git a/tests/cli/test_users.py b/tests/cli/test_users.py index 6538b27..4764c85 100644 --- a/tests/cli/test_users.py +++ b/tests/cli/test_users.py @@ -35,22 +35,23 @@ def test_users_cli_help_lists_management_commands(app: Flask) -> None: def test_users_cli_create_with_prompts_hashes_password(app: Flask) -> None: result = app.test_cli_runner().invoke( - args=["users", "create"], input="alice\nnew-secret\nnew-secret\n" + args=["users", "create"], + input="alice\nmy new secret passphrase\nmy new secret passphrase\n", ) assert result.exit_code == 0, result.output assert "Created user 'alice'." in result.output - assert "new-secret" not in result.output + assert "my new secret passphrase" not in result.output user = _get_user(app, "alice") assert user is not None - assert user.check_password("new-secret") - assert user.password_hash != "new-secret" + assert user.check_password("my new secret passphrase") + assert user.password_hash != "my new secret passphrase" def test_users_cli_create_with_username_option(app: Flask) -> None: result = app.test_cli_runner().invoke( args=["users", "create", "--username", "alice"], - input="new-secret\nnew-secret\n", + input="my new secret passphrase\nmy new secret passphrase\n", ) assert result.exit_code == 0, result.output @@ -61,7 +62,14 @@ def test_users_cli_create_rejects_duplicate(app: Flask) -> None: _add_user(app, "alice") result = app.test_cli_runner().invoke( - args=["users", "create", "--username", "alice", "--password", "other"] + args=[ + "users", + "create", + "--username", + "alice", + "--password", + "a stronger duplicate password", + ] ) assert result.exit_code != 0 @@ -74,7 +82,14 @@ def test_users_cli_create_rejects_duplicate(app: Flask) -> None: @pytest.mark.parametrize("username", ["", " "]) def test_users_cli_create_rejects_invalid_username(app: Flask, username: str) -> None: result = app.test_cli_runner().invoke( - args=["users", "create", "--username", username, "--password", "valid"] + args=[ + "users", + "create", + "--username", + username, + "--password", + "a strong password for testing", + ] ) assert result.exit_code != 0 @@ -117,22 +132,29 @@ def test_users_cli_set_password_updates_hash(app: Flask) -> None: old_hash = _get_user(app, "alice").password_hash # type: ignore[union-attr] result = app.test_cli_runner().invoke( - args=["users", "set-password", "alice"], input="replacement\nreplacement\n" + args=["users", "set-password", "alice"], + input="a long replacement passphrase\na long replacement passphrase\n", ) assert result.exit_code == 0, result.output assert "Updated password for user 'alice'." in result.output - assert "replacement" not in result.output + assert "a long replacement passphrase" not in result.output user = _get_user(app, "alice") assert user is not None assert user.password_hash != old_hash assert not user.check_password("original") - assert user.check_password("replacement") + assert user.check_password("a long replacement passphrase") def test_users_cli_set_password_missing_user(app: Flask) -> None: result = app.test_cli_runner().invoke( - args=["users", "set-password", "missing", "--password", "replacement"] + args=[ + "users", + "set-password", + "missing", + "--password", + "a long replacement passphrase", + ] ) assert result.exit_code != 0 @@ -208,13 +230,19 @@ def test_users_cli_can_manage_legacy_whitespace_username(app: Flask) -> None: _add_user(app, " alice ") reset = app.test_cli_runner().invoke( - args=["users", "set-password", " alice ", "--password", "replacement"] + args=[ + "users", + "set-password", + " alice ", + "--password", + "a long replacement passphrase", + ] ) assert reset.exit_code == 0, reset.output user = _get_user(app, " alice ") assert user is not None - assert user.check_password("replacement") + assert user.check_password("a long replacement passphrase") deleted = app.test_cli_runner().invoke(args=["users", "delete", " alice ", "--yes"]) assert deleted.exit_code == 0, deleted.output @@ -230,9 +258,63 @@ def test_users_cli_create_rolls_back_on_duplicate_race(app: Flask) -> None: patch.object(DATABASE.session, "rollback") as rollback, ): result = app.test_cli_runner().invoke( - args=["users", "create", "--username", "alice", "--password", "secret"] + args=[ + "users", + "create", + "--username", + "alice", + "--password", + "a long secret for testing", + ] ) rollback.assert_called_once() assert result.exit_code != 0 assert "User 'alice' already exists." in result.output + + +@pytest.mark.parametrize( + ("password", "error"), + [ + ("short", "at least 8 characters"), + ("good passphrase with\tab", "control characters"), + ], +) +@pytest.mark.parametrize("operation", ["create", "set-password"]) +def test_users_cli_enforces_password_policy( + app: Flask, password: str, error: str, operation: str +) -> None: + _add_user(app, "existing") + if operation == "create": + command = ["users", "create", "--username", "new"] + else: + command = ["users", "set-password", "existing"] + + result = app.test_cli_runner().invoke(args=[*command, "--password", password]) + assert result.exit_code != 0 + assert error in result.output + assert _get_user(app, "new") is None + existing = _get_user(app, "existing") + assert existing is not None and existing.check_password("original") + + +def test_users_cli_accepts_long_unicode_passphrase(app: Flask) -> None: + passphrase = "🦊 several words of my passphrase 🪁" + result = app.test_cli_runner().invoke( + args=["users", "create", "--username", "alice", "--password", passphrase] + ) + assert result.exit_code == 0, result.output + user = _get_user(app, "alice") + assert user is not None and user.check_password(passphrase) + + +@pytest.mark.parametrize("passphrase", ["12345678", " " * 8, "🦊" + "a" * 1025]) +def test_users_cli_accepts_minimum_whitespace_and_unbounded_passwords( + app: Flask, passphrase: str +) -> None: + result = app.test_cli_runner().invoke( + args=["users", "create", "--username", "alice", "--password", passphrase] + ) + assert result.exit_code == 0, result.output + user = _get_user(app, "alice") + assert user is not None and user.check_password(passphrase) |
