diff options
| author | Dennis Fink | 2026-10-31 17:42:00 +0100 |
|---|---|---|
| committer | Dennis Fink | 2026-10-31 17:42:00 +0100 |
| commit | 6924ad7e52033365c55d5afacdd916c502cc80cb (patch) | |
| tree | 8a52b8e8fbae7a6bcc85d250cac2436a2c42e748 /webmentions_ssg/views | |
| parent | 3494eab1208dc18478485e02c61e292556502fa6 (diff) | |
| download | webmentions-ssg-6924ad7e52033365c55d5afacdd916c502cc80cb.tar.gz webmentions-ssg-6924ad7e52033365c55d5afacdd916c502cc80cb.zip | |
feat(receiver): add resource limits and retention
Bound incoming request and URL sizes so untrusted Webmention submissions
cannot consume unbounded application or database resources.
Purge old failed and deleted received Webmentions on a schedule, and use
portable SHA-256 URL fingerprints to preserve uniqueness for long URLs.
Diffstat (limited to '')
| -rw-r--r-- | webmentions_ssg/views.py | 23 |
1 files changed, 17 insertions, 6 deletions
diff --git a/webmentions_ssg/views.py b/webmentions_ssg/views.py index 1dcdd2e..fcb5f2d 100644 --- a/webmentions_ssg/views.py +++ b/webmentions_ssg/views.py @@ -33,6 +33,7 @@ from .models import ReceivedWebmention, SentWebmention, Source, User from .tasks.receiver import verify_webmention from .tasks.scanner import manual_scan_sources from .tasks.sender import send_webmention +from .url_digest import received_url_digest from .url_security import is_safe_next_url root_page = Blueprint("root", __name__) @@ -339,12 +340,18 @@ def endpoint() -> ResponseReturnValue: source = cast(str, form.source.data) target = cast(str, form.target.data) + url_digest = received_url_digest(source, target) webmention = db.session.execute( - sa.select(ReceivedWebmention).where( - ReceivedWebmention.source == source, ReceivedWebmention.target == target - ) + sa.select(ReceivedWebmention).where(ReceivedWebmention.url_digest == url_digest) ).scalar_one_or_none() + # A SHA-256 collision must never cause an unrelated Webmention to be overwritten. + if webmention is not None and (webmention.source, webmention.target) != ( + source, + target, + ): + return {"error": "Webmention URL fingerprint conflict"}, 409 + should_verify = False if webmention is None: @@ -364,10 +371,14 @@ def endpoint() -> ResponseReturnValue: # after our SELECT but before our COMMIT. webmention = db.session.execute( sa.select(ReceivedWebmention).where( - ReceivedWebmention.source == source, - ReceivedWebmention.target == target, + ReceivedWebmention.url_digest == url_digest ) - ).scalar_one() + ).scalar_one_or_none() + if webmention is None or (webmention.source, webmention.target) != ( + source, + target, + ): + return {"error": "Webmention URL fingerprint conflict"}, 409 else: now = datetime.now(UTC) |
