aboutsummaryrefslogtreecommitdiff
path: root/webmentions_ssg/views/admin.py
diff options
context:
space:
mode:
authorDennis Fink2026-11-14 19:43:28 +0100
committerDennis Fink2026-11-14 19:43:28 +0100
commitc74feda222745ab7cca8993df83d9ea5f9d07e5b (patch)
treeacc7bf9bd7223f9d685d6c2954c5c90d7a9e36f0 /webmentions_ssg/views/admin.py
parente52e554e2d033dd5ef8397617644e90e354f9560 (diff)
downloadwebmentions-ssg-c74feda222745ab7cca8993df83d9ea5f9d07e5b.tar.gz
webmentions-ssg-c74feda222745ab7cca8993df83d9ea5f9d07e5b.zip
refactor(core): use HTTPStatus consistently
Replace numeric HTTP response and assertion codes in views and tests with `HTTPStatus` members so status handling is more descriptive and consistent.
Diffstat (limited to '')
-rw-r--r--webmentions_ssg/views/admin.py11
1 files changed, 6 insertions, 5 deletions
diff --git a/webmentions_ssg/views/admin.py b/webmentions_ssg/views/admin.py
index 1025e69..2ccd92a 100644
--- a/webmentions_ssg/views/admin.py
+++ b/webmentions_ssg/views/admin.py
@@ -5,6 +5,7 @@
"""Authenticated incoming and outgoing Webmention management."""
import uuid
+from http import HTTPStatus
import sqlalchemy as sa
from flask import abort, flash, redirect, render_template, request, url_for
@@ -50,7 +51,7 @@ def delete_received_webmention(identifier: uuid.UUID) -> ResponseReturnValue:
:returns: Redirect response to the received Webmentions view.
"""
if not forms.AdminActionForm().validate_on_submit():
- abort(400)
+ abort(HTTPStatus.BAD_REQUEST)
webmention = db.get_or_404(ReceivedWebmention, identifier)
@@ -75,7 +76,7 @@ def reverify_received_webmention(identifier: uuid.UUID) -> ResponseReturnValue:
:returns: Redirect response to the received Webmentions view.
"""
if not forms.AdminActionForm().validate_on_submit():
- abort(400)
+ abort(HTTPStatus.BAD_REQUEST)
webmention = db.get_or_404(ReceivedWebmention, identifier)
@@ -121,7 +122,7 @@ def rescan_sent_sources() -> ResponseReturnValue:
:returns: Redirect response to the sent Webmentions view.
"""
if not forms.AdminActionForm().validate_on_submit():
- abort(400)
+ abort(HTTPStatus.BAD_REQUEST)
manual_scan_sources()
flash("Source rescan queued.", "success")
@@ -172,12 +173,12 @@ def resend_sent_webmention(
:returns: Redirect response to the source details view.
"""
if not forms.AdminActionForm().validate_on_submit():
- abort(400)
+ abort(HTTPStatus.BAD_REQUEST)
webmention = db.get_or_404(SentWebmention, webmention_identifier)
if webmention.source_id != source_identifier:
- abort(404)
+ abort(HTTPStatus.NOT_FOUND)
# Requeue the existing desired revision instead of inventing a new source
# revision. send_webmention() otherwise exits when this revision has already