aboutsummaryrefslogtreecommitdiff
path: root/tests/test_net.py
diff options
context:
space:
mode:
authorDennis Fink2026-11-13 20:03:49 +0100
committerDennis Fink2026-11-13 20:03:49 +0100
commit87117345ed6e99e5a070d919ac17139cba7b8fe4 (patch)
treed7df5d45008dd2959194e2614b87333598b85198 /tests/test_net.py
parent2fbe1d383650cb31f3ef8d58c04e4d4095935833 (diff)
downloadwebmentions-ssg-87117345ed6e99e5a070d919ac17139cba7b8fe4.tar.gz
webmentions-ssg-87117345ed6e99e5a070d919ac17139cba7b8fe4.zip
fix(core): make network task failures explicit
Introduce a dedicated response-size error so callers only translate expected limit violations instead of masking unrelated `ValueError` exceptions. Ensure failed sockets are always closed, remove dead discovery error handling, and log unexpected sender failures with tracebacks before recording them.
Diffstat (limited to '')
-rw-r--r--tests/test_net.py59
1 files changed, 59 insertions, 0 deletions
diff --git a/tests/test_net.py b/tests/test_net.py
index 05ae5a4..8e0744c 100644
--- a/tests/test_net.py
+++ b/tests/test_net.py
@@ -19,10 +19,12 @@ from webmentions_ssg.net import (
NetworkDeadline,
PublicHTTPTransport,
PublicNetworkBackend,
+ ResponseTooLargeError,
UnsafeAddressError,
is_http_url,
is_public_address,
public_addresses,
+ read_limited_body,
)
@@ -60,6 +62,63 @@ def test_rebinding_cannot_change_socket_peer(monkeypatch: pytest.MonkeyPatch) ->
create_socket.assert_called_once_with(socket.AF_INET, socket.SOCK_STREAM)
+def test_backend_closes_failed_socket_and_tries_next_address(
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ monkeypatch.setattr(
+ "webmentions_ssg.net.public_addresses",
+ Mock(return_value=("93.184.216.34", "8.8.8.8")),
+ )
+ first, second = Mock(), Mock()
+ first.connect.side_effect = TimeoutError("connection timed out")
+ monkeypatch.setattr(socket, "socket", Mock(side_effect=[first, second]))
+
+ stream = PublicNetworkBackend(NetworkDeadline(5)).connect_tcp(
+ "example.com", 443
+ )
+
+ assert isinstance(stream, DeadlineStream)
+ first.close.assert_called_once_with()
+ second.close.assert_not_called()
+ first.connect.assert_called_once_with(("93.184.216.34", 443))
+ second.connect.assert_called_once_with(("8.8.8.8", 443))
+ stream.close()
+ second.close.assert_called_once_with()
+
+
+@pytest.mark.parametrize(
+ ("failure", "expected"),
+ [
+ pytest.param(TimeoutError("timed out"), httpcore.ConnectTimeout, id="timeout"),
+ pytest.param(OSError("refused"), httpcore.ConnectError, id="os-error"),
+ pytest.param(ValueError("unexpected"), ValueError, id="unexpected"),
+ ],
+)
+def test_backend_closes_socket_on_failure(
+ monkeypatch: pytest.MonkeyPatch, failure: Exception, expected: type[Exception]
+) -> None:
+ sock = Mock()
+ sock.connect.side_effect = failure
+ monkeypatch.setattr(socket, "socket", Mock(return_value=sock))
+
+ with pytest.raises(expected, match=str(failure)):
+ PublicNetworkBackend(NetworkDeadline(5)).connect_tcp("8.8.8.8", 443)
+
+ sock.close.assert_called_once_with()
+
+
+@pytest.mark.parametrize("mode", ["declared", "streamed"])
+def test_read_limited_body_raises_specific_size_error(mode: str) -> None:
+ response = (
+ httpx.Response(200, headers={"Content-Length": "11"}, content=b"x" * 11)
+ if mode == "declared"
+ else httpx.Response(200, stream=httpx.ByteStream(b"x" * 11))
+ )
+
+ with pytest.raises(ResponseTooLargeError, match="Source document is too large"):
+ read_limited_body(response, 10, label="Source")
+
+
class FakeStream(httpcore.NetworkStream):
"""In-memory TCP/TLS stream so HTTP framing and SNI can be tested."""