aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDennis Fink2026-11-13 20:26:18 +0100
committerDennis Fink2026-11-13 20:26:18 +0100
commit22f453be12822f1c26f2ba6e229cdc8840ffaa92 (patch)
treef71fac40338d451334fa3aac6bc15213564cd17f
parent8b6326f070c941510ebf1d27e53f501610406ea4 (diff)
downloadwebmentions-ssg-22f453be12822f1c26f2ba6e229cdc8840ffaa92.tar.gz
webmentions-ssg-22f453be12822f1c26f2ba6e229cdc8840ffaa92.zip
refactor(core): remove redundant abort returns
Call Flask `abort` directly in view guards since it always raises and never returns, simplifying error branches without changing response behavior.
Diffstat (limited to '')
-rw-r--r--webmentions_ssg/views/admin.py14
-rw-r--r--webmentions_ssg/views/endpoint.py2
2 files changed, 8 insertions, 8 deletions
diff --git a/webmentions_ssg/views/admin.py b/webmentions_ssg/views/admin.py
index e7c5325..461d329 100644
--- a/webmentions_ssg/views/admin.py
+++ b/webmentions_ssg/views/admin.py
@@ -52,12 +52,12 @@ def delete_received_webmention(identifier: uuid.UUID) -> ResponseReturnValue:
form = forms.AdminActionForm()
if not form.validate_on_submit():
- return abort(400)
+ abort(400)
webmention = db.session.get(ReceivedWebmention, identifier)
if webmention is None:
- return abort(404)
+ abort(404)
db.session.delete(webmention)
db.session.commit()
@@ -82,12 +82,12 @@ def reverify_received_webmention(identifier: uuid.UUID) -> ResponseReturnValue:
form = forms.AdminActionForm()
if not form.validate_on_submit():
- return abort(400)
+ abort(400)
webmention = db.session.get(ReceivedWebmention, identifier)
if webmention is None:
- return abort(404)
+ abort(404)
webmention = webmention.reset_for_verification()
@@ -150,7 +150,7 @@ def sent_source(source_identifier: uuid.UUID) -> ResponseReturnValue:
)
if source is None:
- return abort(404)
+ abort(404)
webmentions = db.paginate(
sa.select(SentWebmention)
@@ -187,12 +187,12 @@ def resend_sent_webmention(
form = forms.AdminActionForm()
if not form.validate_on_submit():
- return abort(400)
+ abort(400)
webmention = db.session.get(SentWebmention, webmention_identifier)
if webmention is None or webmention.source_id != source_identifier:
- return abort(404)
+ abort(404)
# Reopen the existing desired revision instead of inventing a new source
# revision. send_webmention() otherwise exits when this revision has already
diff --git a/webmentions_ssg/views/endpoint.py b/webmentions_ssg/views/endpoint.py
index a94310e..e3f1368 100644
--- a/webmentions_ssg/views/endpoint.py
+++ b/webmentions_ssg/views/endpoint.py
@@ -147,7 +147,7 @@ def status(identifier: uuid.UUID) -> ResponseReturnValue:
webmention = db.session.get(ReceivedWebmention, identifier)
if webmention is None:
- return abort(404)
+ abort(404)
return render_template(
"status.html", title="Webmention status", webmention=webmention